[postgis-devel] extras/tiger_geocoder/upgrade_geocoder.bat and CRLF

[Paul Ramsey]

We do need the CRLF for .bat files or they won't execute on windows, which
is the whole point of them. How to fix the back'n'forth problem is
something I don't know the magic for...
P

On Sun, Aug 6, 2017 at 2:29 PM, Sandro Santilli <strk at kbt.io> wrote:

> I'll add that reading the git log is fun:
>
>   git log --stat extras/tiger_geocoder/upgrade_geocoder.bat
>
> A summary of what you find in there:
>
>   - Regina: do something
>   - Strk: fix line ending
>   - Regina: do something
>   - Strk: fix line ending
>
> It's about time to stop that :)
>
> https://git.osgeo.org/gogs/postgis/postgis/commits/svn-
> trunk/extras/tiger_geocoder/upgrade_geocoder.bat
>
> Regina: please take action or I'm tempted to just change
> .gitattributes *not* to request CRLF in those files...
>
> --strk;
>
> On Sun, Aug 06, 2017 at 11:24:42PM +0200, Sandro Santilli wrote:
> > My git-svn setup insists in adding carriage returns to the
> > extras/tiger_geocoder/upgrade_geocoder.bat file, as requested
> > by the following .gitattribute entry:
> >
> >   *.bat     eol=crlf
> >
> > The carriage returns where stripped by Regina in a recent commit:
> >
> >               commit 0320c64fe2a1b480eef2c4cfa437536152545c22
> >               Author: Regina Obe <lr at pcorp.us>
> >               Date:   Thu Jul 27 16:19:13 2017 +0000
> >
> >                               Geocoder enhancements, add zip4 and
> address_alphanumeric, adjustments to pagc matching
> >                               Closes #3747
> >                               Closes #3748
> >
> >                               git-svn-id: http://svn.osgeo.org/postgis/
> trunk at 15508 b70326c6-7e19-0410-871a-916f4a2858ee
> >
> >                extras/tiger_geocoder/upgrade_geocoder.bat | 38
> +++++++++++++++++++-------------------
> >                1 file changed, 19 insertions(+), 19 deletions(-)
> >
> > So the question now is: is the .gitattribute entry not reflected in the
> > SVN world ? Does anyone know how to reflect it ? Note that I'm happy with
> > never using carriage-returns, as long as we are consistent about it...
> >
> > --strk;
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20170806/0cfd9569/attachment.html>