<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6000.16481" name=GENERATOR></HEAD>
<BODY
style="WORD-WRAP: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space">
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>Dane,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>Thanks. That would help. I've started to fix
these as I go along adding examples. </FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>I don't know if we should get rid of issue 35 though.
I think the intent is still the same its just the actual implementation may be
different and I was looking at your python and your comments as guidelines of
what is wrong with the documentation.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>Is there an issue with having more than one <term>
in the varlistentry. The html xsl parse just seems to put in a , when
forming the html so I assume its okay to do that.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>E.g. I changed Add Point entry to:</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2> <varlistentry><BR>
<term>ST_AddPoint(linestring geometry, point
geometry)</term><BR> <term>ST_AddPoint(linestring
geometry, point geometry, position integer)</term></FONT></SPAN></DIV>
<DIV> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff
size=2>
<listitem><BR>
<para>Adds a point to a LineString before point
<position><BR>
(0-based index). Third parameter can be omitted or set to -1
for<BR>
appending.</para><BR>
<programlisting><BR>--guarantee all linestrings in a table are
closed<BR>--by adding the start point of each linestring to the end of the line
string <BR>--only for those that are not closed<BR>UPDATE sometable<BR> SET
the_geom = ST_AddPoint(the_geom, ST_StartPoint(the_geom))<BR> FROM
sometable<BR> WHERE ST_IsClosed(the_geom) =
false;<BR>
</programlisting><BR>
</listitem><BR>
</varlistentry></FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>I was next going to attempt to write a postgis_comments.xsl
(finally I have a use for this xslt pocket book I have lying around :)) .
I haven't done that yet though and not sure I'm the best person to attempt
that.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>Thanks,</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=874062219-07072008><FONT face=Arial
color=#0000ff size=2>Regina</FONT></SPAN></DIV><BR>
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B>
postgis-devel-bounces@postgis.refractions.net
[mailto:postgis-devel-bounces@postgis.refractions.net] <B>On Behalf Of </B>Dane
Springmeyer<BR><B>Sent:</B> Monday, July 07, 2008 1:59 PM<BR><B>To:</B> PostGIS
Development Discussion<BR><B>Subject:</B> Re: [postgis-devel] Issue 35 in
postgis: Comments on Postgis Functions<BR></FONT><BR></DIV>
<DIV></DIV>Regina and Paul,
<DIV><BR></DIV>
<DIV>
<DIV>
<DIV>I agree that a python script dependency for this step isn't ideal, and I'm
in no way committed to the idea. It was simply an easy way for me to start
working on the task, and I was not anticipating its consideration as a
dependency.</DIV>
<DIV><BR></DIV>
<DIV>I propose we close this issue 35 as invalid and cook up another one based
on Regina's sweet plan. How does that sound?</DIV>
<DIV><BR></DIV>
<DIV>More comments below...</DIV>
<DIV><BR></DIV>
<DIV><BR></DIV>
<DIV>On Jul 6, 2008, at 1:57 AM, Obe, Regina wrote:</DIV><BR
class=Apple-interchange-newline>
<BLOCKQUOTE type="cite">
<DIV>
<DIV id=idOWAReplyText16337 dir=ltr>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Paul,</FONT></DIV>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>You must have been reading
my mind when you selectively picked this one and the proj one to not comment
about.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>Regarding this I have been looking at
Dane's submission and as Paul mentioned, off list, its not good to add any
more dependencies than we need to. This would require adding Python and
Python's pgsql library to use his source.</FONT></DIV></DIV></DIV></BLOCKQUOTE>
<DIV><BR></DIV>Yes, it requires Python and the Psycopg2 driver as well as an
existing db to match function names against (due to variable argument
syntax).</DIV>
<DIV><BR>
<BLOCKQUOTE type="cite">
<DIV>
<DIV id=idOWAReplyText16337 dir=ltr>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>My main gripe with it is that it requires
a postgis_template db to be loaded to build the comments. It seems the
main reason for that is to look up the arg signature in the procname which
would seem to be unnecessary if our argument list in the documents could be
mapped to the postgresql function
signature.</FONT></DIV></DIV></DIV></BLOCKQUOTE>
<DIV><BR></DIV>
<DIV>Exactly. It could easily be modified to match against an xml file (or
internal python data type) that stores the exact function names and arguments,
but having the docs more closely match the actual function definitions would be
ideal.</DIV> <BR>
<BLOCKQUOTE type="cite">
<DIV>
<DIV id=idOWAReplyText16337 dir=ltr>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>In many cases they do or almost do.
But we have cases like</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><SPAN class=term>ST_MakePolygon(linestring,
[linestring[]])</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>which if we changed to</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>ST_MakePolygon(linestring geometry, linestrings
geometry[])</SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN
class=term>ST_MakePolygon(linestring)</SPAN></SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>would work.</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV></DIV></DIV></BLOCKQUOTE>
<BLOCKQUOTE type="cite">
<DIV>
<DIV id=idOWAReplyText16337 dir=ltr>
<DIV dir=ltr><SPAN class=term>the only issue I can think of are these
functions with multi-signatures</SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term>ST_AddPoint(linestring, point,
[<position>])</SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term></SPAN></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term>I personally would prefer see
it listed twice as</SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN
class=term>ST_AddPoint(linestring geometry, point
geometry)</SPAN></SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN
class=term></SPAN></SPAN></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN class=term><SPAN
class=term>ST_AddPoint(linestring geometry, point geometry, position
integer)</SPAN></SPAN></SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN class=term><SPAN
class=term></SPAN></SPAN></SPAN></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term><SPAN class=term><SPAN class=term><SPAN
class=term>since I'm not convinced non-programmers don't find that
nomenclature confusing.</SPAN></SPAN></SPAN></SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>then I'm thinking we can generate the
postgis_comments.sql.in from a simple</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>postgis_comments.xsl file that parses the
postgis.xml thus not needing another dependency.</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>Although I could very well be trivializing the
simplicity of this.</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term>Does anyone have issues with me changing the doc
accordingly. </SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV></DIV></DIV></BLOCKQUOTE>
<DIV><BR></DIV>
<DIV>This sounds excellent. I'd be happy to help with this renaming if it is
needed.</DIV>
<DIV><BR></DIV>
<DIV><BR></DIV>
<DIV>Cheers,</DIV>
<DIV><BR></DIV>
<DIV>Dane</DIV>
<DIV><BR></DIV>
<DIV><BR></DIV>
<DIV><BR></DIV><BR>
<BLOCKQUOTE type="cite">
<DIV>
<DIV id=idOWAReplyText16337 dir=ltr>
<DIV dir=ltr><SPAN class=term>Thanks,</SPAN></DIV>
<DIV dir=ltr><SPAN class=term>Regina</SPAN></DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV>
<DIV dir=ltr><SPAN class=term></SPAN> </DIV></DIV>
<DIV dir=ltr><BR>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> <A
href="mailto:postgis-devel-bounces@postgis.refractions.net">postgis-devel-bounces@postgis.refractions.net</A>
on behalf of <A
href="mailto:codesite-noreply@google.com">codesite-noreply@google.com</A><BR><B>Sent:</B>
Thu 7/3/2008 5:47 PM<BR><B>To:</B> <A
href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</A><BR><B>Subject:</B>
[postgis-devel] Issue 35 in postgis: Comments on Postgis
Functions<BR></FONT><BR></DIV>
<DIV>
<P><FONT size=2>Issue 35: Comments on Postgis Functions<BR><A
href="http://code.google.com/p/postgis/issues/detail?id=35">http://code.google.com/p/postgis/issues/detail?id=35</A><BR><BR>Comment
#2 by pwramsey3:<BR>(No comment was entered for this change.)<BR><BR><BR>Issue
attribute updates:<BR> Labels:
-Type-Defect Type-Enhancement<BR><BR>--<BR>You received this message because
you are listed in the owner<BR>or CC fields of this issue, or because you
starred this issue.<BR>You may adjust your issue notification preferences
at:<BR><A
href="http://code.google.com/hosting/settings">http://code.google.com/hosting/settings</A><BR>_______________________________________________<BR>postgis-devel
mailing list<BR><A
href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</A><BR><A
href="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A><BR></FONT></P></DIV></DIV>
<DIV>
<DIV><BR class=webkit-block-placeholder></DIV>
<HR SIZE=1>
<DIV><BR class=webkit-block-placeholder></DIV>
<P><STRONG>The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure pursuant to
Massachusetts law. It is intended solely for the addressee. If you received
this in error, please contact the sender and delete the material from any
computer. </STRONG></P></DIV>
<DIV><BR class=webkit-block-placeholder></DIV>
<HR SIZE=1>
<DIV><BR class=webkit-block-placeholder></DIV>
<P><STRONG><FONT color=#339900 size=2>Help make the earth a greener place. If
at all possible resist printing this email and join us in saving paper.
</FONT></STRONG></P><STRONG><FONT color=#339900 size=2></FONT></STRONG>
<P><STRONG><FONT color=#339900
size=2></FONT></STRONG></P>_______________________________________________<BR>postgis-devel
mailing list<BR><A
href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</A><BR>http://postgis.refractions.net/mailman/listinfo/postgis-devel<BR></BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>
<HTML><BODY><P><hr size=1></P>
<P><STRONG>
The substance of this message, including any attachments, may be confidential, legally privileged and/or exempt from disclosure pursuant to Massachusetts law. It is intended solely for the addressee. If you received this in error, please contact the sender and delete the material from any computer.
</STRONG></P></BODY></HTML>
<P><hr size=1></P>
<P><STRONG><font size="2" color="339900"> Help make the earth a greener place. If at all possible resist printing this email and join us in saving paper. </p> <p> </font></STRONG></P>