<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7652.24">
<TITLE>RE: [postgis-devel] Use ofdeprecated functionsin non-deprecatedfunctions</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>Kevin,<BR>
<BR>
I still have reservations.<BR>
<BR>
It gets a bit iffy<BR>
later on down the line if we start deprecating auto-magic stuff I<BR>
guess was part of my thinking. I was also thinking someone coming along<BR>
may not realize the distinction between using an sql function and a plpgsql<BR>
function and arbitrarily copy the wrong approach thus accidentally slowing down performance.<BR>
<BR>
Now I think about it, those things would be easy to catch anyway.<BR>
<BR>
Although if we put a notice in there wouldn't it always be spitting out the NOTICE for each call which could potentially slow down older applications.<BR>
<BR>
Take the example of<BR>
<BR>
SELECT Area(the_geom)<BR>
FROM sometable<BR>
<BR>
Wouldn't it spit out a notice for each call which could slow things down a lot or maybe it doesn't work as I expect. In which case would be fine with me. <BR>
<BR>
Thanks,<BR>
Regina<BR>
<BR>
-----Original Message-----<BR>
From: postgis-devel-bounces@postgis.refractions.net on behalf of Kevin Neufeld<BR>
Sent: Tue 7/29/2008 12:08 PM<BR>
To: PostGIS Development Discussion<BR>
Subject: Re: [postgis-devel] Use ofdeprecated functionsin non-deprecatedfunctions<BR>
<BR>
Yes, I totally agree. Sorry I wasn't clear. I meant that if we ever<BR>
were to start throwing NOTICEs on deprecated functions, I would think<BR>
the way to do that would be to change the deprecated functions that<BR>
reference the c directly into plpgsql functions.<BR>
<BR>
IE.<BR>
"crosses" and "_crosses" both reference the c library directly. Since<BR>
we can't throw a NOTICE in the c function (since it would look like<BR>
"_crosses" is also deprecated) we would need to change "crosses" to an<BR>
aliased plpgsql function that first throws a NOTICE and then calls<BR>
"_crosses".<BR>
<BR>
I realize now that this topic is a little different than what you<BR>
brought up a couple of posts ago.<BR>
<BR>
Cheers,<BR>
Kevin<BR>
<BR>
<BR>
Obe, Regina wrote:<BR>
> You wouldn't want to do that. plpgsql is opaque to the planner. For<BR>
> things such as ST_Intersects, ST_DWithin, ST_Within and all those<BR>
> automagically indexed functions, they will become automagically stupid.<BR>
><BR>
> Regina<BR>
><BR>
> -----Original Message-----<BR>
> From: postgis-devel-bounces@postgis.refractions.net<BR>
> [<A HREF="mailto:postgis-devel-bounces@postgis.refractions.net">mailto:postgis-devel-bounces@postgis.refractions.net</A>] On Behalf Of<BR>
> Kevin Neufeld<BR>
> Sent: Monday, July 28, 2008 1:16 PM<BR>
> To: PostGIS Development Discussion<BR>
> Subject: Re: [postgis-devel] Use of deprecated functionsin<BR>
> non-deprecatedfunctions<BR>
><BR>
> Obe, Regina wrote:<BR>
>> ... just wanted to verify there was no issue with referencing the<BR>
> lwpostgis c functions directly in all the aliased functions. <BR>
>> Thanks,<BR>
>> Regina<BR>
>><BR>
><BR>
> Are we planning some time in the future to start throwing NOTICEs /<BR>
> ERRORs on deprecated function use? If so, I would think the easiest way<BR>
><BR>
> to do this would be through the simple wrappers we have now (though<BR>
> we'll have to convert the SQL wrappers to plpgsql wrappers).<BR>
><BR>
> Cheers,<BR>
> -- Kevin<BR>
> _______________________________________________<BR>
> postgis-devel mailing list<BR>
> postgis-devel@postgis.refractions.net<BR>
> <A HREF="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A><BR>
> -----------------------------------------<BR>
> The substance of this message, including any attachments, may be<BR>
> confidential, legally privileged and/or exempt from disclosure<BR>
> pursuant to Massachusetts law. It is intended<BR>
> solely for the addressee. If you received this in error, please<BR>
> contact the sender and delete the material from any computer.<BR>
><BR>
> _______________________________________________<BR>
> postgis-devel mailing list<BR>
> postgis-devel@postgis.refractions.net<BR>
> <A HREF="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A><BR>
_______________________________________________<BR>
postgis-devel mailing list<BR>
postgis-devel@postgis.refractions.net<BR>
<A HREF="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A><BR>
<BR>
</FONT>
</P>
</BODY>
</HTML>