<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 6.5.7653.38">
<TITLE>RE: [postgis-devel] STYLE</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->
<P><FONT SIZE=2>This I mentioned to Mark offlist, but since its sort of a STYLE issue I thought I would restate it here.<BR>
<BR>
I know C programmers are in love with doing this short-cut. <BR>
<BR>
if (!binary) free(v);<BR>
<BR>
I hate it. It drives me crazy because its too prone to error when someone comes<BR>
by and tries to stuff another statement in there and forgets to put the bracket in.<BR>
<BR>
Can we add to style guide to use the more verbose convention<BR>
<BR>
if (!binary){<BR>
free(v);<BR>
}<BR>
<BR>
Thanks,<BR>
Regina<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: postgis-devel-bounces@postgis.refractions.net on behalf of Mark Cave-Ayland<BR>
Sent: Fri 12/19/2008 6:52 AM<BR>
To: PostGIS Development Discussion<BR>
Subject: Re: [postgis-devel] STYLE<BR>
<BR>
Paul Ramsey wrote:<BR>
<BR>
> <A HREF="http://svn.refractions.net/postgis/trunk/STYLE">http://svn.refractions.net/postgis/trunk/STYLE</A><BR>
><BR>
> This is not meant to be the last word, it's just a draft, please add<BR>
> your changes as you see fit (you in particular, Mark).<BR>
><BR>
> On a related note, as I work with liblwgeom, I wish we had more API<BR>
> documentation than the header file... I think doxygen will work fine<BR>
> w/ C. should we commit to doxygen as our in-code standard?<BR>
><BR>
> P.<BR>
<BR>
This looks entirely sensible, nice work Paul :) I think at some point<BR>
we should just add a script to the repo that will indent all the .c/.h<BR>
files (excluding those used to generate .sql.in files) and run it as we<BR>
hit RC. Doxygen is something I've not personally used, although I've<BR>
used equivalents for PHP etc. Have you got any example files in trunk I<BR>
could run it on to take a look?<BR>
<BR>
BTW I noticed your r3450 commit, and this got me thinking. One of things<BR>
that really trips me up at the moment is LWCURVE - why oh why was it not<BR>
called LWCIRCSTRING??! This tends to trip me up a lot, since SQL-MM<BR>
defines a curve as a LINESTRING or a CIRCULARSTRING and so makes the<BR>
logic a lot harder to follow when trying to map SQL types to C types.<BR>
<BR>
So would anyone really object if I performed another massively invasive<BR>
substitution to get this out of my system for once and for all on trunk?<BR>
I promise not to break the build ;)<BR>
<BR>
<BR>
ATB,<BR>
<BR>
Mark.<BR>
<BR>
--<BR>
Mark Cave-Ayland<BR>
Sirius Corporation - The Open Source Experts<BR>
<A HREF="http://www.siriusit.co.uk">http://www.siriusit.co.uk</A><BR>
T: +44 870 608 0063<BR>
_______________________________________________<BR>
postgis-devel mailing list<BR>
postgis-devel@postgis.refractions.net<BR>
<A HREF="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A><BR>
<BR>
<BR>
</FONT>
</P>
</BODY>
</HTML>
<HTML><BODY><P><hr size=1></P>
<P><STRONG>
The substance of this message, including any attachments, may be confidential, legally privileged and/or exempt from disclosure pursuant to Massachusetts law. It is intended solely for the addressee. If you received this in error, please contact the sender and delete the material from any computer.
</STRONG></P></BODY></HTML>
<P><hr size=1></P>
<P><STRONG><font size="2" color="339900"> Help make the earth a greener place. If at all possible resist printing this email and join us in saving paper. </p> <p> </font></STRONG></P>