<html>
<head>
<title></title>
<meta name="GENERATOR" content="MSHTML 8.00.6001.18828"></meta>
</head>
<body>
<div align="left">ok, I will try to complement the documentation. As Paus says I can put the algoritm description in the wiki. Do you want more from that Mark. There has become some more to describe like this subgeometry handling that I only described with a few words in #231.</div>
<div align="left"> </div>
<div align="left">I will also write down a list of what I have done and why.</div>
<div align="left"> </div>
<div align="left">How to give evidence for the testing I don't know. Some tests I have put in the regression tests.</div>
<div align="left"> </div>
<div align="left">I have thought about making som sort of theme with descriptions about what functions is called at what situation but I guess doxygen satisfies most of that need if the code gets into the trunk.</div>
<div align="left"> </div>
<div align="left">And just a comment about Pauls last post.</div>
<div align="left">The new algoritm as implemented in the spike is used when geometries bboxes doesn't overlap and no of the geometries is a point.</div>
<div align="left">Maybe it shouldn't be used for lines and polygons with just a few vertexes. I haven't really tested but it seems to be faster in most cases. It would be possible to use the new algoritm on one of the geometries and iterate every vertex on the other, but I don't think that is worth the effort.</div>
<div align="left"> </div>
<div align="left">I'll get back</div>
<div align="left">No peace to expect Paul :-)</div>
<div align="left"> </div>
<div align="left"> </div>
<div align="left">/Nicklas<br />
<br />
2009-11-07 Paul Ramsey wrote:<br />
<br />
My understanding is that the code is pretty modular and only activates<br />
>for the particular large geometry cases it performs well for. Perhaps<br />
>Niklas could put his .doc explanation, which is good, into the wiki<br />
>where it's more webbly accessed. I'll be looking for a number of CUnit<br />
>tests that run and compare both methods on a variety of inputs.<br />
><br />
>p.<br />
><br />
>On Sat, Nov 7, 2009 at 3:03 AM, Mark Cave-Ayland<br />
>
<mark.cave-ayland@siriusit.co.uk></mark.cave-ayland@siriusit.co.uk> wrote:<br />
>> Paul Ramsey wrote:<br />
>><br />
>>> Niklas,<br />
>>> I'm going to start reviewing your distance work on Monday, speak now<br />
>>> or forever hold your peace :)<br />
>>> P.<br />
>><br />
>> I don't think reading the code will be a problem - my main concern is the<br />
>> lack of documentation for the algorithm changes. I'd like to see better<br />
>> documentation of the changes present in Niklas' spike (new algorithm<br />
>> descriptions and reason for change, clear evidence of testing) before<br />
>> agreeing to commit.<br />
>><br />
>><br />
>> ATB,<br />
>><br />
>> Mark.<br />
>><br />
>> --<br />
>> Mark Cave-Ayland - Senior Technical Architect<br />
>> PostgreSQL - PostGIS<br />
>> Sirius Corporation plc - control through freedom<br />
>> http://www.siriusit.co.uk<br />
>> t: +44 870 608 0063<br />
>><br />
>> Sirius Labs: http://www.siriusit.co.uk/labs<br />
>> _______________________________________________<br />
>> postgis-devel mailing list<br />
>> postgis-devel@postgis.refractions.net<br />
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel<br />
>><br />
>_______________________________________________<br />
>postgis-devel mailing list<br />
>postgis-devel@postgis.refractions.net<br />
>http://postgis.refractions.net/mailman/listinfo/postgis-devel<br />
><br />
></div>
</body>
</html>