<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3c.org/TR/1999/REC-html401-19991224/loose.dtd">
<HTML><HEAD><TITLE></TITLE>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.7601.17573"></HEAD>
<BODY>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>Nicklas,</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>Hmm I forgot about that one keeping astyle separate
from logic commit. </SPAN></FONT><FONT color=#0000ff size=2
face=Arial><SPAN class=441095206-14052011>Once a week sounds reasonable to
me. </SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>Chris et. al ,</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>You think we could schedule say once a week a job to do
an svn astyle commit? As Nicklas says, it will probably be a lot of files
in the beginning but few</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>each successive time.</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>I amended the commit guidelines to hyperlink to our
below astyle guidelines.</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=441095206-14052011>I still need to put in Pierre's recommendation
changes.</SPAN></FONT></DIV><BR>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B>
postgis-devel-bounces@postgis.refractions.net
[mailto:postgis-devel-bounces@postgis.refractions.net] <B>On Behalf Of
</B>Nicklas Avén<BR><B>Sent:</B> Saturday, May 14, 2011 2:53 AM<BR><B>To:</B>
PostGIS Development Discussion<BR><B>Subject:</B> Re: [postgis-devel] Astyle
Bot<BR></FONT><BR></DIV>
<DIV></DIV>
<P>Hallo <BR><BR>----- Original message ----- <BR>> I'm not sure if this is
the 4th or 5th time this has come up... <BR>> <BR><BR>sorry <BR>I must have
missed 2 or 3 of them. <BR><BR><BR>> This causes future commits to
potentially fail, and there is NO WAY to <BR>> update your client because it
thinks that everything is happily the same <BR>> updated version as is in the
repo. <BR>> <BR><BR>Ok I see th problem. <BR><BR><BR><BR>> We could do an
automatic process to go in after an update and checkout <BR>> any changed
files, restyle them, and commit them, but then our SVN <BR>> history is full
of "restyle" commits. This causes confusion when looking <BR>> for "who/what
broke the build?" and generally just seems messy to me... <BR>> comparably
messy to just having an irregularly styled codebase. <BR><BR>i am not sure I
agree here. according to our style guidelines: <BR><A
href="http://trac.osgeo.org/postgis/browser/trunk/STYLE">http://trac.osgeo.org/postgis/browser/trunk/STYLE</A>
<BR>we are supposed to do the style-committ separerately anyway. <BR>But I agree
that it would be messy to do it after each commit. <BR><BR>Maybe a middleway
would be to run it once a week automatically with a fixed easy to see message. i
don't think that commit will mess up the timeline too much and the code will not
be too messed up in one week if we try to keep the style manually.
<BR><BR>/nicklas <BR><BR><BR><BR><BR><BR><BR>> <BR>> What we could do is
put a pre-commit hook in SVN that runs astyle and <BR>> looks for changes -
if there are any, then the commit is rejected, and <BR>> you have to run
astyle yourself before committing. However, due to the <BR>> apparent lack of
compatibility between versions of astyle, this doesn't <BR>> seem to work
either. Perhaps we could include a version of astyle or a <BR>> similar
script inside postgis? Similar to including autoconf-generated <BR>> tools.
Then we can ensure that the same formatting is being run on both <BR>> the
SVN server and all clients. I don't know whether this is possible <BR>> with
astyle or if there is another tool that could do it? <BR>> <BR>> Not to
start a holy war but I don't really have a problem with <BR>> formatting in
general. Compared to Mapserver, the PostGIS code looks <BR>> great! But then,
more developers == more differences. So anyways I'm <BR>> pretty indifferent
about the "solution" to this "problem". <BR>> <BR>> Chris <BR>>
<BR>> <BR>> On 13/05/2011 1:22 PM, Paragon Corporation wrote: <BR>>
> +1 <BR>> > <BR>> > Strk and Nicklas, <BR>> > But I
thought we had this discussion and putting in an SVN hook or a <BR>> >
smart Astyle bot was only in our dreams? Is it possible? <BR>> >
<BR>> > Thanks <BR>> > Regina <BR>> > <BR>> > On Fri,
May 13, 2011 at 12:30:06PM +0200, Nicklas Avén wrote: <BR>> > <BR>>
> > We run a lot of different jobs building documentation, building
<BR>> > > postgis for regresstest and so on. <BR>> > >
<BR>> > > Why is it a problem to run astyle somewhere in the chain too?
<BR>> > +1 on this, let's have bots cleanup the code for us. <BR>> >
<BR>> > --strk; <BR>> > <BR>> > <BR>> >
_______________________________________________ <BR>> > postgis-devel
mailing list <BR>> > <A
href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</A>
<BR>> > <A
href="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A>
<BR>> <BR>> _______________________________________________ <BR>>
postgis-devel mailing list <BR>> <A
href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</A>
<BR>> <A
href="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</A>
<BR>> <BR><BR></P></BODY></HTML>