<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="Osso Notes">
<title></title></head>
<body>
<p>Hallo
<br>
<br>----- Original message -----
<br>> I'm not sure if this is the 4th or 5th time this has come up...
<br>>
<br>
<br>sorry
<br>I must have missed 2 or 3 of them.
<br>
<br>
<br>> This causes future commits to potentially fail, and there is NO WAY to
<br>> update your client because it thinks that everything is happily the same
<br>> updated version as is in the repo.
<br>>
<br>
<br>Ok I see th problem.
<br>
<br>
<br>
<br>> We could do an automatic process to go in after an update and checkout
<br>> any changed files, restyle them, and commit them, but then our SVN
<br>> history is full of "restyle" commits. This causes confusion when looking
<br>> for "who/what broke the build?" and generally just seems messy to me...
<br>> comparably messy to just having an irregularly styled codebase.
<br>
<br>i am not sure I agree here. according to our style guidelines:
<br><a href="http://trac.osgeo.org/postgis/browser/trunk/STYLE">http://trac.osgeo.org/postgis/browser/trunk/STYLE</a>
<br>we are supposed to do the style-committ separerately anyway.
<br>But I agree that it would be messy to do it after each commit.
<br>
<br>Maybe a middleway would be to run it once a week automatically with a fixed easy to see message. i don't think that commit will mess up the timeline too much and the code will not be too messed up in one week if we try to keep the style manually.
<br>
<br>/nicklas
<br>
<br>
<br>
<br>
<br>
<br>
<br>>
<br>> What we could do is put a pre-commit hook in SVN that runs astyle and
<br>> looks for changes - if there are any, then the commit is rejected, and
<br>> you have to run astyle yourself before committing. However, due to the
<br>> apparent lack of compatibility between versions of astyle, this doesn't
<br>> seem to work either. Perhaps we could include a version of astyle or a
<br>> similar script inside postgis? Similar to including autoconf-generated
<br>> tools. Then we can ensure that the same formatting is being run on both
<br>> the SVN server and all clients. I don't know whether this is possible
<br>> with astyle or if there is another tool that could do it?
<br>>
<br>> Not to start a holy war but I don't really have a problem with
<br>> formatting in general. Compared to Mapserver, the PostGIS code looks
<br>> great! But then, more developers == more differences. So anyways I'm
<br>> pretty indifferent about the "solution" to this "problem".
<br>>
<br>> Chris
<br>>
<br>>
<br>> On 13/05/2011 1:22 PM, Paragon Corporation wrote:
<br>> > +1
<br>> >
<br>> > Strk and Nicklas,
<br>> > But I thought we had this discussion and putting in an SVN hook or a
<br>> > smart Astyle bot was only in our dreams? Is it possible?
<br>> >
<br>> > Thanks
<br>> > Regina
<br>> >
<br>> > On Fri, May 13, 2011 at 12:30:06PM +0200, Nicklas Avén wrote:
<br>> >
<br>> > > We run a lot of different jobs building documentation, building
<br>> > > postgis for regresstest and so on.
<br>> > >
<br>> > > Why is it a problem to run astyle somewhere in the chain too?
<br>> > +1 on this, let's have bots cleanup the code for us.
<br>> >
<br>> > --strk;
<br>> >
<br>> >
<br>> > _______________________________________________
<br>> > postgis-devel mailing list
<br>> > <a href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</a>
<br>> > <a href="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</a>
<br>>
<br>> _______________________________________________
<br>> postgis-devel mailing list
<br>> <a href="mailto:postgis-devel@postgis.refractions.net">postgis-devel@postgis.refractions.net</a>
<br>> <a href="http://postgis.refractions.net/mailman/listinfo/postgis-devel">http://postgis.refractions.net/mailman/listinfo/postgis-devel</a>
<br>>
<br><br></p>
</body>
</html>