<div dir="ltr">ok strk,<div>Will take a look at your comments and clean up the code.</div><div><br></div><div>Regards,</div><div>Mohit</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 25, 2014 at 8:47 PM, Sandro Santilli <span dir="ltr"><<a href="mailto:strk@keybit.net" target="_blank">strk@keybit.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mohit, I've added some inline comments on your commit.<br>
Can it be you accidentally added two files that should not be<br>
there at all (duplication of PostgreSQL internals) ?<br>
<br>
I hope you can cleanup those changes so it's easier to review them.<br>
Please remove anything which is not necessary and possibly provide<br>
a recipe to test the use of the new index.<br>
<br>
--strk;<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Jun 25, 2014 at 05:06:28PM +0200, Sandro Santilli wrote:<br>
> On Wed, Jun 25, 2014 at 04:57:44PM +0530, mohit kumar wrote:<br>
> > Hi sandro,<br>
> > I have forked the postgis repository at<br>
> > <a href="https://github.com/mohitkharb/postgis" target="_blank">https://github.com/mohitkharb/postgis</a> and am creating a pull request but<br>
> > its not happening.<br>
><br>
> What does it mean "its not happening" ?<br>
><br>
> Forget the pull request, I'll look at your commit directly:<br>
> <a href="https://github.com/mohitkharb/postgis/commit/d0d87512" target="_blank">https://github.com/mohitkharb/postgis/commit/d0d87512</a><br>
> <a href="https://github.com/mohitkharb/postgis/commit/d0d87512.patch" target="_blank">https://github.com/mohitkharb/postgis/commit/d0d87512.patch</a><br>
><br>
> Report the above urls in the trac ticket please, for review.<br>
><br>
> --strk;<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div>Mohit Kumar<div>+91-970-3840-175<div>Lab For Spatial Informatics<br>International Institute of Information Technology<br>Hyderabad, India</div>
</div></div></div>
</div>