<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><div><div><div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p><div><p class=MsoNormal style='margin-left:.5in'>2016-07-22 8:11 GMT+02:00 Regina Obe <<a href="mailto:lr@pcorp.us" target="_blank">lr@pcorp.us</a>>:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal style='margin-left:1.0in'><br>5) BRIN support -- I think some cleanup is still left with that patch being<br>worked on, but looks pretty close for commit. -<br><a href="https://github.com/postgis/postgis/pull/106" target="_blank">https://github.com/postgis/postgis/pull/106</a> So I would consider it a done<br>deal except, it's not in our code base yet. I want this in before<br>mid-August so we can start stress testing it <o:p></o:p></p></blockquote></div><p class=MsoNormal style='margin-left:83.55pt'><o:p> </o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>About this: I and Julien Rouhaud have already received some comments about our patch<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>presented in the pull request <a href="https://github.com/postgis/postgis/pull/106">https://github.com/postgis/postgis/pull/106</a>: we have already<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>fixed some issues (support for empty entries, make testing "more light") emerged in the<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>pull request's discussion, and we are waiting for further review of the patch, and ready for<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>further changes/fixing.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'><br>We have also pointed up that travis CI currently runs regression tests on a 9.4 cluster,<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>so a "successful check" just means that configure steps successfully ignore BRIN code in<br>pre 9.5 clusters (since BRIN support has been added in 9.5, and our patch correctly manages<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:119.55pt'>the various cases). Anyway, regression tests run successfully for 9.5 and 9.6beta3 clusters.<o:p></o:p></p><p class=MsoNormal style='margin-left:1.5in'><br clear=all><o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:1.0in'>Regards,<o:p></o:p></p></div><div><p class=MsoNormal style='mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:1.0in'>Giuseppe.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:.5in'>-- <o:p></o:p></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Giuseppe,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I've tested this out and looks generally good. I'm ready to commit, assuming no one has any issues with that (speak now or forever hold your peace), except for one small little thing which I noted in the pull request.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>The work as it stands fails our non-extension uninstall test. To resolve this I'd like to rename the operator families to the same name as the operator classes so it's consistent with the rest of our code base and also so I don't have to muck with our perl uninstall generation script. As I mentioned, extension installs don't use this script for uninstall (they just use the built-in uninstall plumbing of extension), but our pre-extension test uses this.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I've already done this locally, so just a <b>Yes </b>that's okay is all I'm looking for or why you are against that.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><a href="https://github.com/postgis/postgis/pull/106">https://github.com/postgis/postgis/pull/106</a><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Regina<o:p></o:p></span></p></div></div></div></div></body></html>