<div dir="ltr">Hi Regina,<br><div><div class="gmail_extra"><br><div class="gmail_quote">2016-07-29 20:29 GMT+02:00 Regina Obe <span dir="ltr"><<a href="mailto:lr@pcorp.us" target="_blank">lr@pcorp.us</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div link="blue" vlink="purple" lang="EN-US"><div><div><div><span class=""><div><p class="MsoNormal"><br><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"></span></p></div></span><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Giuseppe,<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I've tested this out and looks generally good.  I'm ready to commit, assuming no one has any issues with that (speak now or forever hold your peace), except for one small little thing which I noted in the pull request.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">The work as it stands fails our non-extension uninstall test.  To resolve this I'd like to rename the operator families to the same name as the operator classes so it's consistent with the rest of our code base and also so I don't have to muck with our perl uninstall generation script.  As I mentioned, extension installs don't use this script for uninstall (they just use the built-in uninstall plumbing of extension), but our pre-extension test uses this.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I've already done this locally, so just a <b>Yes </b>that's okay is all I'm looking for or why you are against that.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><a href="https://github.com/postgis/postgis/pull/106" target="_blank">https://github.com/postgis/postgis/pull/106</a></span></p></div></div></div></div></div></blockquote><div><br></div><div>There is no problem in renaming the OpFamily. Sorry, I've understood that you already proceeded with this. So yes, please rename it (is the problem present just for the geography OpFamily?).<br></div></div><br></div><div class="gmail_extra">Regards,<br></div><div class="gmail_extra">Giuseppe.<br><br></div><div class="gmail_extra">-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><span></span>Giuseppe Broccolo - 2ndQuadrant Italy
<br>PostgreSQL & PostGIS Training, Services and Support
<br><a href="mailto:giuseppe.broccolo@2ndQuadrant.it" target="_blank">giuseppe.broccolo@2ndQuadrant.it</a> | <a href="http://www.2ndQuadrant.it" target="_blank">www.2ndQuadrant.it</a>
</div></div></div></div>
</div></div></div>