<div dir="ltr">I'm ok with doing formatting before editing of code, file by file, if that seems feasible on writing.<br>I think that thread started with people being unhappy about me doing so.<br><br>I have two questions then:<div><br><div> - do we have to blend into the style of <a href="https://github.com/postgis/postgis/blob/svn-trunk/extensions/address_standardizer/gamma.c#L142" target="_blank">https://github.com/postgis/postgis/blob/svn-trunk/extensions/address_standardizer/gamma.c#L142</a> if editing around it, or there is an option to clean it up before?</div><div><br></div><div> - do we follow the <a href="https://github.com/postgis/postgis/blob/svn-trunk/STYLE#L27" target="_blank">https://github.com/postgis/postgis/blob/svn-trunk/STYLE#L27</a>, to the letter or to the spirit?</div><br><br><div class="gmail_quote"><div dir="ltr">ср, 28 февр. 2018 г. в 20:25, Regina Obe <<a href="mailto:lr@pcorp.us" target="_blank">lr@pcorp.us</a>>:<br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_8519259031007736720m_-9130199836864231622WordSection1"><p class="MsoNormal" style="margin-left:.5in">+1 for stop f**king with formatting.<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8519259031007736720m_-9130199836864231622WordSection1"><p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> postgis-devel [mailto:<a href="mailto:postgis-devel-bounces@lists.osgeo.org" target="_blank">postgis-devel-bounces@lists.osgeo.org</a>] <b>On Behalf Of </b>Bborie Park<br><b>Sent:</b> Wednesday, February 28, 2018 11:21 AM<br><b>To:</b> PostGIS Development Discussion <<a href="mailto:postgis-devel@lists.osgeo.org" target="_blank">postgis-devel@lists.osgeo.org</a>><br><b>Subject:</b> Re: [postgis-devel] Code formatting digging in<u></u><u></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8519259031007736720m_-9130199836864231622WordSection1"><p class="MsoNormal" style="margin-left:.5in"><u></u> <u></u></p><div><div><p class="MsoNormal" style="margin-left:.5in">+1 for stop f**king with formatting.<u></u><u></u></p></div><div><p class="MsoNormal" style="margin-left:.5in"><u></u> <u></u></p></div><div><p class="MsoNormal" style="margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">I wonder when we'll get to debating camel vs snake.<u></u><u></u></p><div><p class="MsoNormal" style="margin-left:.5in">-bborie<u></u><u></u></p></div><div><p class="MsoNormal" style="margin-left:.5in"><u></u> <u></u></p><div><p class="MsoNormal" style="margin-left:.5in">On Feb 28, 2018 08:15, "Paul Ramsey" <<a href="mailto:pramsey@cleverelephant.ca" target="_blank">pramsey@cleverelephant.ca</a>> wrote:<u></u><u></u></p><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"><p class="MsoNormal" style="margin-left:.5in">+1. The issue is additional dependencies and minimal effort for devs<br>to create identical results. An embedded formatter like astyle or<br>pgindent gives us the easiest way of achieving that. (Another proposed<br>solution: stop f___ing with formatting. I know, it's an impossible<br>dream.)<br><span style="color:#888888"><br>P.</span><u></u><u></u></p><div><p class="MsoNormal" style="margin-left:.5in"><br>On Wed, Feb 28, 2018 at 8:09 AM, Sandro Santilli <<a href="mailto:strk@kbt.io" target="_blank">strk@kbt.io</a>> wrote:<br>> On Wed, Feb 28, 2018 at 02:34:08PM +0000, Darafei "Komяpa" Praliaskouski wrote:<br>><br>>> TLDR: pgindent heavily broken, style ported to clang-format, let's use<br>>> clang-format with pgindent style.<br>><br>> Maybe you failed to understand the reason "pgindent" was considered<br>> better than "clang-format": possibility to shipt the tool with PostGIS.<br>><br>> If "pgindent" is broken I suggest to file issues upstream:<br>><br>> <a href="https://git.postgresql.org/git/pg_bsd_indent.git" target="_blank">https://git.postgresql.org/git/pg_bsd_indent.git</a><br>><br>> According to Tomas this would be the same code as the one also<br>> embedded in PostgreSQL, but maybe that's not the case ?<br>><br>> <a href="https://github.com/postgres/postgres/tree/master/src/tools/pgindent" target="_blank">https://github.com/postgres/postgres/tree/master/src/tools/pgindent</a><br>><br>>> Some practices from pgindent and postgres code stylestill can be adopted<br>>> though even the tool does not fit. I ported Postgres brace style to<br>>> .clang-format in my PR.<br>><br>> I really don't care about which style is choosen, as long as we can<br>> make it easy for any contributor to produce patches that will meet<br>> the criteria our build bots will expect.<br>><br>> At the moment the proposed solutions are:<br>><br>> tool | additional dependencies<br>> ---------------------+-------------------------------------<br>> embedded pgindent |<br>> ---------------------+-------------------------------------<br>> embedded astyle | a C++ compiler<br>> ---------------------+-------------------------------------<br>> clang-format | clang-format of a specific version<br>> ---------------------+-------------------------------------<br>><br>> --strk;<br>><br>> () Free GIS & Flash consultant/developer<br>> /\ <a href="https://strk.kbt.io/services.html" target="_blank">https://strk.kbt.io/services.html</a><br>> _______________________________________________<br>> postgis-devel mailing list<br>> <a href="mailto:postgis-devel@lists.osgeo.org" target="_blank">postgis-devel@lists.osgeo.org</a><br>> <a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><br>_______________________________________________<br>postgis-devel mailing list<br><a href="mailto:postgis-devel@lists.osgeo.org" target="_blank">postgis-devel@lists.osgeo.org</a><br><a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><u></u><u></u></p></div></blockquote></div><p class="MsoNormal" style="margin-left:.5in"><u></u> <u></u></p></div></div></div></div></div>_______________________________________________<br>
postgis-devel mailing list<br>
<a href="mailto:postgis-devel@lists.osgeo.org" target="_blank">postgis-devel@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a></blockquote></div></div></div>