<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal style='margin-left:.5in'>+1 for stop f**king with formatting.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal style='margin-left:.5in'><b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'> postgis-devel [mailto:postgis-devel-bounces@lists.osgeo.org] <b>On Behalf Of </b>Bborie Park<br><b>Sent:</b> Wednesday, February 28, 2018 11:21 AM<br><b>To:</b> PostGIS Development Discussion <postgis-devel@lists.osgeo.org><br><b>Subject:</b> Re: [postgis-devel] Code formatting digging in<o:p></o:p></span></p><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p><div><div><p class=MsoNormal style='margin-left:.5in'>+1 for stop f**king with formatting.<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p></div><div><p class=MsoNormal style='mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in'>I wonder when we'll get to debating camel vs snake.<o:p></o:p></p><div><p class=MsoNormal style='margin-left:.5in'>-bborie<o:p></o:p></p></div><div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p><div><p class=MsoNormal style='margin-left:.5in'>On Feb 28, 2018 08:15, "Paul Ramsey" <<a href="mailto:pramsey@cleverelephant.ca">pramsey@cleverelephant.ca</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal style='margin-left:.5in'>+1. The issue is additional dependencies and minimal effort for devs<br>to create identical results. An embedded formatter like astyle or<br>pgindent gives us the easiest way of achieving that. (Another proposed<br>solution: stop f___ing with formatting. I know, it's an impossible<br>dream.)<br><span style='color:#888888'><br>P.</span><o:p></o:p></p><div><p class=MsoNormal style='margin-left:.5in'><br>On Wed, Feb 28, 2018 at 8:09 AM, Sandro Santilli <<a href="mailto:strk@kbt.io">strk@kbt.io</a>> wrote:<br>> On Wed, Feb 28, 2018 at 02:34:08PM +0000, Darafei "Komяpa" Praliaskouski wrote:<br>><br>>> TLDR: pgindent heavily broken, style ported to clang-format, let's use<br>>> clang-format with pgindent style.<br>><br>> Maybe you failed to understand the reason "pgindent" was considered<br>> better than "clang-format": possibility to shipt the tool with PostGIS.<br>><br>> If "pgindent" is broken I suggest to file issues upstream:<br>><br>> <a href="https://git.postgresql.org/git/pg_bsd_indent.git" target="_blank">https://git.postgresql.org/git/pg_bsd_indent.git</a><br>><br>> According to Tomas this would be the same code as the one also<br>> embedded in PostgreSQL, but maybe that's not the case ?<br>><br>> <a href="https://github.com/postgres/postgres/tree/master/src/tools/pgindent" target="_blank">https://github.com/postgres/postgres/tree/master/src/tools/pgindent</a><br>><br>>> Some practices from pgindent and postgres code stylestill can be adopted<br>>> though even the tool does not fit. I ported Postgres brace style to<br>>> .clang-format in my PR.<br>><br>> I really don't care about which style is choosen, as long as we can<br>> make it easy for any contributor to produce patches that will meet<br>> the criteria our build bots will expect.<br>><br>> At the moment the proposed solutions are:<br>><br>> tool | additional dependencies<br>> ---------------------+-------------------------------------<br>> embedded pgindent |<br>> ---------------------+-------------------------------------<br>> embedded astyle | a C++ compiler<br>> ---------------------+-------------------------------------<br>> clang-format | clang-format of a specific version<br>> ---------------------+-------------------------------------<br>><br>> --strk;<br>><br>> () Free GIS & Flash consultant/developer<br>> /\ <a href="https://strk.kbt.io/services.html" target="_blank">https://strk.kbt.io/services.html</a><br>> _______________________________________________<br>> postgis-devel mailing list<br>> <a href="mailto:postgis-devel@lists.osgeo.org">postgis-devel@lists.osgeo.org</a><br>> <a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><br>_______________________________________________<br>postgis-devel mailing list<br><a href="mailto:postgis-devel@lists.osgeo.org">postgis-devel@lists.osgeo.org</a><br><a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><o:p></o:p></p></div></blockquote></div><p class=MsoNormal style='margin-left:.5in'><o:p> </o:p></p></div></div></div></div></body></html>