<div dir="ltr">Hi,<div><br><a href="https://trac.osgeo.org/postgis/changeset/16452">https://trac.osgeo.org/postgis/changeset/16452</a> is performed by <span style="font-family:Verdana,Arial,"Bitstream Vera Sans",Helvetica,sans-serif">Bborie Park and not me. </span></div><div><span style="font-family:Verdana,Arial,"Bitstream Vera Sans",Helvetica,sans-serif">Can this be re-addressed? :)</span><br></div></div><br><div class="gmail_quote"><div dir="ltr">вс, 11 мар. 2018 г. в 10:15, Sandro Santilli <<a href="mailto:strk@kbt.io">strk@kbt.io</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Komzpa I saw you modified RFC2-WellKnownBinaryFormat in r16452 but<br>
didn't read any thread on postgis-devel reguarding the change.<br>
<br>
Those documents are important references and should be changed<br>
lightly so please revert the change and propose changes on this<br>
mailing list.<br>
<br>
Note that the header of the file contains revision information,<br>
which you didn't update with your changes.<br>
<br>
Specifically your change shifted the last 2 "pixtype" values from<br>
9,10 to 10,10 thus leaving a gap in 9:<br>
<br>
+---------------+--------------+-----------------------------------+<br>
| pixtype | 4bits | 0: 1-bit boolean |<br>
| | | 1: 2-bit unsigned integer |<br>
| | | 2: 4-bit unsigned integer |<br>
| | | 3: 8-bit signed integer |<br>
| | | 4: 8-bit unsigned integer |<br>
| | | 5: 16-bit signed integer |<br>
| | | 6: 16-bit unsigned signed integer |<br>
| | | 7: 32-bit signed integer |<br>
| | | 8: 32-bit unsigned signed integer |<br>
| | | 10: 32-bit float |<br>
| | | 11: 64-bit float |<br>
+---------------+--------------+-----------------------------------+<br>
<br>
Is it possible you're updating RFC to match some buggy code ?<br>
<br>
--strk;<br>
</blockquote></div>