<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hey Regina,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks for the interest. No problem with the current feature freeze, I think that's great if we have it for 3.0. Meanwhile I'll work on your proposed changes and if someone needs this functionality the new code/patch
will be available.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">For the code sprint I'd love to go and hack in PostGIS stuff but it will be difficult. I'm going to FOSS4G Tanzania and it will be difficult for me to justify this code sprint.</p>
<div><br>
</div>
<div>Thanks</div>
<div>Luis Calisto</div>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> postgis-devel <postgis-devel-bounces@lists.osgeo.org> on behalf of Regina Obe <lr@pcorp.us><br>
<b>Sent:</b> Thursday, July 5, 2018 10:31 AM<br>
<b>To:</b> 'PostGIS Development Discussion'<br>
<b>Subject:</b> Re: [postgis-devel] TPI with custom focal mean radius</font>
<div> </div>
</div>
<meta content="text/html; charset=Windows-1252">
<meta name="x_Generator" content="Microsoft Word 15 (filtered medium)">
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="x_WordSection1">
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Luis,</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Unfortunately we are at feature freeze for PostGIS 2.5.0, so this can't go into PostGIS 2.5.0 since it would change/add signatures</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">We also wouldn't reopen the ticket, but would require a new ticket detailing the enhancement.</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Could go in for next release which is tentatively planned to be 3.0 (at least a year's away). We'll be focusing on this at our upcoming code sprint in late
September</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><a href="https://trac.osgeo.org/postgis/wiki/PostGISCodeSprint2018" id="LPlnk795731" class="OWAAutoLink" previewremoved="true">https://trac.osgeo.org/postgis/wiki/PostGISCodeSprint2018</a></span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">which you are welcome to join if you want to hack on PostGIS stuff.</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">That said, a couple of changes we'd need for this to accept.</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Ideally, this would extend the existing ST_TPI with additional args, so the following changes would need to be made</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoListParagraph" style="text-indent:-.25in"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><span style="">1)<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">A new ticket detailing the enhancement</span></p>
<p class="x_MsoListParagraph" style="text-indent:-.25in"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><span style="">2)<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Change name to ST_TPI</span></p>
<p class="x_MsoListParagraph" style="text-indent:-.25in"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><span style="">3)<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Move the irad, and orad to the end – so that the signature is backward compatible with the existing ST_TPI signature.</span></p>
<p class="x_MsoListParagraph" style="text-indent:-.25in"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><span style="">4)<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Add regression tests</span></p>
<p class="x_MsoListParagraph" style="text-indent:-.25in"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"><span style="">5)<span style="font:7.0pt "Times New Roman"">
</span></span></span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Amend
</span><span style="font-family:"Calibri",sans-serif; color:black"> <a href="https://postgis.net/docs/RT_ST_TRI.html" id="LPlnk917512" class="OWAAutoLink" previewremoved="true">https://postgis.net/docs/RT_ST_TRI.html</a> no include new signature</span><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"></span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">There's some other stuff about how you upgrade an existing function to accept new args, but I can take care of that and just explain for future contributions.</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Thanks,</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D">Regina</span></p>
<p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#1F497D"> </span></p>
<div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif"> postgis-devel [mailto:postgis-devel-bounces@lists.osgeo.org]
<b>On Behalf Of </b>Luis Calisto<br>
<b>Sent:</b> Thursday, July 05, 2018 5:30 AM<br>
<b>To:</b> postgis-devel@lists.osgeo.org<br>
<b>Subject:</b> [postgis-devel] TPI with custom focal mean radius</span></p>
</div>
</div>
<p class="x_MsoNormal"> </p>
<div id="x_divtagdefaultwrapper">
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">Hi,</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">Current ST_TPI implementation only supports a focalmean radius of one. Out of need I had to implement a solution in PostGIS that implements TPI with a custom focal mean. This
solution is now on my github: <a href="https://github.com/lcalisto/postgis_customTPI/" id="LPlnk226868" class="OWAAutoLink" previewremoved="true">
https://github.com/lcalisto/postgis_customTPI/</a> I believe it can be interesting to contribute this code to current ST_TPI implementation maybe someone else also needs it.</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">You think we should reopen this ticket?
<a href="https://trac.osgeo.org/postgis/ticket/2163" id="LPlnk506200" class="OWAAutoLink" previewremoved="true">
https://trac.osgeo.org/postgis/ticket/2163</a></span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">If you think it's interesting I can also, and easily, do the same for TRI.
<a href="https://postgis.net/docs/RT_ST_TRI.html" id="LPlnk200958" class="OWAAutoLink" previewremoved="true">
https://postgis.net/docs/RT_ST_TRI.html</a></span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">Regards</span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
<div>
<p class="x_MsoNormal"><span style="font-family:"Calibri",sans-serif; color:black">Luis Calisto</span></p>
</div>
<p style="margin-bottom:12.0pt"><span style="font-family:"Calibri",sans-serif; color:black"> </span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>