<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>Looking at the graphs I can't grok meaningfulness of mean 99% CI on graph page 13 - it feels like mean is in the saddle of camel-shaped distribution. </div><div>Why are there two distinct peaks?</div><div><br></div><div>Otherwise I like how you fixed up wagyu. Can the changes be upstreamed so that pulling new version is a matter of file copy later?. </div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 14, 2019 at 1:39 PM Raúl Marín Rodríguez <<a href="mailto:rmrodriguez@carto.com">rmrodriguez@carto.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
Since the PR has grown quite a bit and includes several fixes to the current<br>
implementation and new tests, I'm going to start pushing all the things that<br>
aren't directly related to wagyu (and backporting when necessary) to cleanup<br>
the PR as much as possible.<br>
<br>
If anyone is interested in this change you can see the performance difference<br>
in [1]. Depending on the size of the polygon after the simplification process<br>
it can be up to 27x faster. After some improvements, I don't see any case<br>
where wagyu is slower and the only caveat is that it might drop very small<br>
polygons.<br>
<br>
Also since I've only tested this in Linux, other OS might require some extra<br>
tweaking of the build scripts, so if you'd like to help please try to build<br>
and run it (passing the `--with-wagyu` flag to configure)<br>
<br>
[1] - <a href="https://github.com/postgis/postgis/files/2754774/20190111_geos_vs_20190111_wagyu.pdf" rel="noreferrer" target="_blank">https://github.com/postgis/postgis/files/2754774/20190111_geos_vs_20190111_wagyu.pdf</a><br>
<br>
Regards<br>
<br>
-- <br>
Raúl Marín Rodríguez<br>
<a href="http://carto.com" rel="noreferrer" target="_blank">carto.com</a><br>
_______________________________________________<br>
postgis-devel mailing list<br>
<a href="mailto:postgis-devel@lists.osgeo.org" target="_blank">postgis-devel@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div>Darafei Praliaskouski</div><div>Support me: <a href="http://patreon.com/komzpa" target="_blank">http://patreon.com/komzpa</a></div></div></div></div>