<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Greg, All -</p>
<p> as part of OSGeoLive 2020 on Ubuntu Focal, I am working with
sethg from Mapserver project and noticed the following in the
build recipe for mapserver Debian packaging:</p>
<p> <tt>apt-get install --allow-unauthenticated
protobuf-c-compiler libprotobuf-c-dev</tt><br>
</p>
<div class="moz-cite-prefix">This seems to shows security vetting on
<b>protobuf</b> adding a new layer of checks to library origin and
content at build time. This apparent trend needs to be considered
along with PostGIS project goals, to decide on what libraries are
optional and what are not, in a build. Personally, I consider
civilian access to strong computer science a high priority, with
appropriate disclosure and documentation along with it.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"> best regards from Berkeley,
California --Brian M Hamlin / MAPLABS</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 6/26/20 8:52 AM, Greg Troxel wrote:<br>
</div>
<blockquote type="cite" cite="mid:rmio8p57rki.fsf@s1.lexort.com">
<pre class="moz-quote-pre" wrap=""><a class="moz-txt-link-abbreviated" href="mailto:rmrodriguez@carto.com">rmrodriguez@carto.com</a> writes:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Please let me know when you've had the chance of testing it. If it
works correctly I'll push the fixes to 3.0 and the future 3.1.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I found the github web interface remarkably difficult in that there was
no obvious way to download a patch for those commits. But I added your
repo as a remote to my clone of the official repo, and ran git diff....
With that applied to the 3.0.1 release, and rerunning autoconf, I was
able to build without pkg-config, json-c, protobuf-c exposd to the
build, and 'make check' passed.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">It might be reasonable to just say 'pkg-config is required', test for
it, and error out if not.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I think we still officially support dependencies that didn't use
pkg-config (and they they started using it), but I think it would
indeed make sense to start requiring pkg-config to simplify both the
management and errors in different environments.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I didn't mean to require that all dependencies be found via pkg-config.
I meant to require pkg-config to be present to build postgis at all.
Then each dependency can be moved to pkg-config only as that is
reasonable.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">I guess it would be nice if README.postgis explained really clearly what
was gained or lost by having it. (I realize I tend to be particularly
demanding about these sorts of doc/advice things.)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I see that README.postgis does mention that protobuf-c is necessary
for ST_AsMVT and ST_AsGeoBuf. How would you reword it to make it
clearer?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I guess my request is unreasonable, but I'd like someone who is building
binaries for others to be able to tell if they should
1) impose the protobuf dependency on everyone, letting those two
functions work, or
2) omit protobuf, have those functions not work, and have everybody
not have the dependency
which is really a question of whether being handed a binary postgis
install that is missing protobuf is 1) normal or 2) defective. I'm
trying to separate "SHOULD have this dependency (but we can build
without it)" from "this is weird and if you want to do this, add it".
But really you can just tell me wich is which.
_______________________________________________
postgis-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:postgis-devel@lists.osgeo.org">postgis-devel@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/postgis-devel">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a>
</pre>
</blockquote>
</body>
</html>