<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">I feel like the most “standard” thing to do would be to convert them all to assert()s and then have a<div><br></div><div>—enable-assert </div><div><br></div><div>option. And then we can add other asserts to our heart’s content without having to know about this weird option Dave invented back in 2004.</div><div><br></div><div>P<br><div><br><blockquote type="cite"><div>On Jan 18, 2024, at 2:25 PM, Paul Ramsey <pramsey@cleverelephant.ca> wrote:</div><br class="Apple-interchange-newline"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">There are only a handful of uses (grep for "PARANOIA_LEVEL >”) and except for one they are all testing > 0. So I think an on/off, or potentially just strip them out. I never flip them on, on purpose, and have never assumed anything other than that it was always off (imagine my surprise to find it on).<div><br></div><div>P<br><div><div><div><br><blockquote type="cite"><div>On Jan 18, 2024, at 2:23 PM, Sandro Santilli <strk@kbt.io> wrote:</div><br class="Apple-interchange-newline"><div><meta charset="UTF-8"><span style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">On Thu, Jan 18, 2024 at 04:25:55PM -0500, Regina Obe wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" style="font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite">On Thu, Jan 18, 2024 at 08:13:04AM -0800, Paul Ramsey wrote:<br><blockquote type="cite">Just a reminder, if you build postgis with —enable-debug, the<br></blockquote>PARANOIA_LEVEL gets bumped up, and that can have huge performance effects<br>which make any kind of benchmarking a whack-a-mole process.<br><blockquote type="cite"><br>I guess I internalized the idea that —enable-debug would just drop a ‘-g’ flag<br></blockquote>into the build and that’s about it, but in fact it has these other deleterious effects.<br>Among other things, it makes lwcollection_add_lwgeom a couple orders of<br>magnitude slower.<br><blockquote type="cite"><br>Anyways, super important for anyone building for release too. You aren’t just<br></blockquote>getting debug symbols!<br><blockquote type="cite"><br>I wonder if we should split off —enable-debug from other “developer<br></blockquote>affordances”, in a different option, kind of like how pgsql as —enable-cassert and<br>some other #define only options for things like memory checking and so on.<br><br>+1 --enable-paranoia would sound good<br></blockquote><br>+1<br></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Actually I guess it should be --with-paranoia-level N</span><br style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span style="caret-color: rgb(0, 0, 0); font-family: HelveticaNeue; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">--strk;</span></div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div></body></html>