[postgis-tickets] [PostGIS] #2909: bad dependency expression results in rule firing on subsequent make, and make install

[PostGIS]

#2909: bad dependency expression results in rule firing on subsequent make, and
make install
-----------------------------------+----------------------------------------
 Reporter:  gdt                    |       Owner:  strk 
     Type:  defect                 |      Status:  new  
 Priority:  low                    |   Milestone:       
Component:  build/upgrade/install  |     Version:  trunk
 Keywords:                         |  
-----------------------------------+----------------------------------------
 In several makefiles, e.g extensions/postgis/Makefile.in, there is a rule:

 {{{
 sql_minor_upgrade: sql_bits/extension_upgrade_minor.sql
         for OLD_VERSION in $(UPGRADEABLE_VERSIONS_MINOR); do \
           cat $< > sql/$(EXTENSION)--$$OLD_VERSION--$(EXTVERSION).sql; \
         done
 }}}

 which results in the following being executed on a subsequent make, and on
 make install, because no file sql_minor_upgrade is created.

 {{{
 ---- Making all in postgis
 gmake[3]: Entering directory '/u0/n0/gdt/NetBSD-current/pkgsrc/wip
 /postgresql-postgis2/work/postgis-2.1.3/extensions/postgis'
 for OLD_VERSION in 2.0.0 2.0.1 2.0.2 2.0.3 2.0.4 2.0.5; do \
           cat sql_bits/extension_upgrade_minor.sql >
 sql/postgis--$OLD_VERSION--2.1.3.sql; \
 done
 for OLD_VERSION in 2.1.0rc1 2.1.0rc2 2.1.0rc3 2.1.0 2.1.1 2.1.2; do \
           cat sql_bits/extension_upgrade_patch.sql >
 sql/postgis--$OLD_VERSION--2.1.3.sql; \
 done
 gmake[3]: Leaving directory '/u0/n0/gdt/NetBSD-current/pkgsrc/wip
 /postgresql-postgis2/work/postgis-2.1.3/extensions/postgis'
 }}}

 To fix, probably the phony target should be created by the rule body, so
 that it doesn't get reexecuted.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2909>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.