r16364 - lwpoly_construct_circle: Avoid division by zero (Raúl Marín Rodríguez)

Paul Ramsey pramsey at cleverelephant.ca
Fri Jan 26 07:01:15 PST 2018


Author: pramsey
Date: 2018-01-26 07:01:15 -0800 (Fri, 26 Jan 2018)
New Revision: 16364

Modified:
   trunk/liblwgeom/lwpoly.c
Log:
lwpoly_construct_circle: Avoid division by zero (Raúl Marín Rodríguez)
Closes #4003
Closes #199


Modified: trunk/liblwgeom/lwpoly.c
===================================================================
--- trunk/liblwgeom/lwpoly.c	2018-01-26 14:56:52 UTC (rev 16363)
+++ trunk/liblwgeom/lwpoly.c	2018-01-26 15:01:15 UTC (rev 16364)
@@ -120,13 +120,13 @@
 lwpoly_construct_circle(int srid, double x, double y, double radius, uint32_t segments_per_quarter, char exterior)
 {
 	const uint32_t segments = 4*segments_per_quarter;
-	const double theta = 2*M_PI / segments;
+	double theta;
 	LWPOLY *lwpoly;
 	POINTARRAY *pa;
 	POINT4D pt;
 	uint32_t i;
 
-	if (segments_per_quarter < 1)
+	if (segments_per_quarter == 0)
 	{
 		lwerror("Need at least one segment per quarter-circle.");
 		return NULL;
@@ -138,6 +138,8 @@
 		return NULL;
 	}
 
+	theta = 2*M_PI / segments;
+
 	lwpoly = lwpoly_construct_empty(srid, LW_FALSE, LW_FALSE);
 	pa = ptarray_construct_empty(LW_FALSE, LW_FALSE, segments + 1);
 



More information about the postgis-tickets mailing list