[postgis-tickets] [PostGIS] #4128: ST_AsMVT: add feature id support

[PostGIS]

#4128: ST_AsMVT: add feature id support
---------------------------+---------------------------
  Reporter:  stepankuzmin  |      Owner:  pramsey
      Type:  enhancement   |     Status:  reopened
  Priority:  medium        |  Milestone:  PostGIS 3.0.0
 Component:  postgis       |    Version:
Resolution:                |   Keywords:
---------------------------+---------------------------
Changes (by Algunenano):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I have several objections to this change:
 - It doesn't include documentation.
 - The `id` column is added twice, once in the `id` field and one as a
 property. This duplicates information making tiles bigger for no reason.
 - If there are multiple columns with the same name there will be extra
 work done.
 - IMO it should throw if the type is invalid, not just silently ignore it.
 It's not documented which types are supported.
 - The check is added in a hot path and it's done for each property for
 each feature. Instead it should be done, as with the geometry column, once
 at the start. I expect this to have an important impact on performance,
 even when not using this feature.

 I'm reopening it to have a look into metrics and document this new feature
 properly.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4128#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.