[postgis-tickets] [PostGIS] #4687: Expose GEOS MaximumInscribedCircle

PostGIS trac at osgeo.org
Fri May 8 06:41:50 PDT 2020


#4687: Expose GEOS MaximumInscribedCircle
--------------------------+---------------------------
  Reporter:  pramsey      |      Owner:  pramsey
      Type:  enhancement  |     Status:  assigned
  Priority:  high         |  Milestone:  PostGIS 3.1.0
 Component:  postgis      |    Version:  master
Resolution:               |   Keywords:
--------------------------+---------------------------

Comment (by Algunenano):

 Hi, I've left a couple of comments in the PR. Also, this is breaking
 regress tests:

 {{{
  geos39 .. failed (diff expected obtained: /tmp/pgis_reg/test_129_diff)
 }}}

 {{{
 --- geos39_expected     2020-05-08 15:23:05.538587889 +0200
 +++ /tmp/pgis_reg/test_129_out  2020-05-08 15:35:38.296144156 +0200
 @@ -2,5 +2,5 @@
  mic-empty|POINT EMPTY|POINT EMPTY|0.0000
  mic-null|||
  mic-line|POINT(50 50)|POINT(50 0)|50.0000
 -mic-mpoint|POINT(50 50)|POINT(0 0)|70.7107
 +mic-mpoint|POINT(50 50)|POINT(100 0)|70.7107
  mic-point|POINT(0 0)|POINT(0 0)|0.0000
 }}}

 Same error in debbie:
 https://debbie.postgis.net/job/PostGIS_Regress/14401/console

 {{{
 13:34:21
 -----------------------------------------------------------------------------
 13:34:21 --- geos39_expected    2020-05-07 22:24:46.048294273 +0000
 13:34:21 +++
 /var/lib/jenkins/workspace/postgis/tmp/3_1_pg12w64/test_129_out
 2020-05-08 13:34:21.752346491 +0000
 13:34:21 @@ -2,5 +2,5 @@
 13:34:21  mic-empty|POINT EMPTY|POINT EMPTY|0.0000
 13:34:21  mic-null|||
 13:34:21  mic-line|POINT(50 50)|POINT(50 0)|50.0000
 13:34:21 -mic-mpoint|POINT(50 50)|POINT(0 0)|70.7107
 13:34:21 +mic-mpoint|POINT(50 50)|POINT(100 0)|70.7107
 13:34:21  mic-point|POINT(0 0)|POINT(0 0)|0.0000
 13:34:21
 -----------------------------------------------------------------------------
 }}}

 I'll update the latest travis image in case you want to fight against it
 directly. Keep in mind that raster are currently broken there
 (https://trac.osgeo.org/postgis/ticket/4673), but core regress tests
 should work (TM)

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4687#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-tickets mailing list