[postgis-tickets] [PostGIS] #5193: mixed qualification of pg_catalog arguments

[PostGIS]

#5193: mixed qualification of pg_catalog arguments
---------------------+---------------------------
 Reporter:  strk     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  medium   |  Milestone:  PostGIS 3.3.0
Component:  postgis  |    Version:  master
 Keywords:           |
---------------------+---------------------------
 I stumbled upon this line in postgis.sql:
 ```
 postgis/postgis.sql.in:548:CREATE OR REPLACE FUNCTION
 _postgis_selectivity(tbl pg_catalog.regclass, att_name text, geom
 geometry, mode text default '2')
 ```

 and wondering why do we qualify "regclass" but not "text"

 I don't know what's important to qualify but the inconsistency I don't
 understand.

 NOTE: I found this out while trying to match the `CREATE OR REPLACE
 FUNCTION` lines in our SQL file to what's already present in the database,
 comparing against the output of `pg_get_function_identity_arguments`
 function which (for the record) NEVER qualifies `pg_catalog`, even if it's
 not explicitly in your search_path
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5193>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.