[postgis-tickets] [PostGIS] #5261: PostgreSQL 16 GUC changes breaks compile, removal of Abs breaks compile (was: PostgreSQL 16 GUC changes breaks compile)

[PostGIS]

#5261: PostgreSQL 16 GUC changes breaks compile, removal of Abs breaks compile
----------------------+---------------------------
  Reporter:  robe     |      Owner:  robe
      Type:  defect   |     Status:  new
  Priority:  blocker  |  Milestone:  PostGIS 3.4.0
 Component:  postgis  |    Version:  master
Resolution:           |   Keywords:  PG16
----------------------+---------------------------
Changes (by robe):

 * summary:  PostgreSQL 16 GUC changes breaks compile =>
     PostgreSQL 16 GUC changes breaks compile, removal of Abs breaks
     compile

Comment:

 Okay I think this one I have under control maybe, but that just allowed
 stumbling into yet another break

 https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a699b7a7aa9f34c19aa7632b3f037f24c8ee7720


 {{{
 Remove Abs()
 author  Peter Eisentraut <peter at eisentraut.org>
         Wed, 12 Oct 2022 04:36:12 +0000 (06:36 +0200)
 committer       Peter Eisentraut <peter at eisentraut.org>
         Wed, 12 Oct 2022 04:53:47 +0000 (06:53 +0200)
 commit  a699b7a7aa9f34c19aa7632b3f037f24c8ee7720
 tree    f1b387b4cddc0e2857cb4ed80f98ab6bb31096e5        tree
 parent  4574eb9d38c69f4c90b5468f740ff22519752066        commit | diff
 Remove Abs()

 All callers have been replaced by standard C library functions.

 Reviewed-by: Zhang Mingli <zmlpostgres at gmail.com>
 Reviewed-by: Tom Lane <tgl at sss.pgh.pa.us>
 Discussion: https://www.postgresql.org/message-id/flat/4beb42b5-216b-
 bce8-d452-d924d5794c63%40enterprisedb.com
 }}}

 Which is causing a break in


 {{{
 gserialized_gist_2d.o: In function `gserialized_gist_picksplit_2d':
 C:\ming64gcc81\projects\postgis\postgis-
 git\postgis/gserialized_gist_2d.c:2057: undefined reference to `Abs'
 collect2.exe: error: ld returned 1 exit status
 make[1]: ***
 [C:/MING64~1/projects/POSTGR~1/rel/PG16W6~3/lib/pgxs/src/MAKEFI~1/../../src/Makefile.shlib:339:
 postgis-3.4.dll] Error 1
 make[1]: Leaving directory '/projects/postgis/postgis-git/postgis'

 }}}

 I'm thinking we should just replace this one with abs -- can't think of a
 reason to keep it.
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5261#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.