[postgis-tickets] [PostGIS] #5486: Upgrade from 3.2.1 fails due to deprecating two flavors of st_dwithin

[PostGIS]

#5486: Upgrade from 3.2.1  fails due to deprecating two flavors of st_dwithin
------------------------------------+---------------------------
  Reporter:  strk                   |      Owner:  strk
      Type:  defect                 |     Status:  new
  Priority:  medium                 |  Milestone:  PostGIS 3.3.5
 Component:  build/upgrade/install  |    Version:  3.3.x
Resolution:                         |   Keywords:
------------------------------------+---------------------------
Comment (by strk):

 Oddly Dronie has no trouble upgrading from 3.2.2 to 3.5.0dev:
 https://dronie.osgeo.org/postgis/postgis/4824/1/3

 But I can't tell the same on my local system:
 {{{
 Upgrade path: 3.2.2 --> 3.5.0dev
 Database postgis_reg already exists, dropping.
 Creating database 'postgis_reg'
 Preparing db 'postgis_reg' using: CREATE EXTENSION postgis VERSION '3.2.2'
 SCHEMA public
 Preparing db 'postgis_reg' using: CREATE EXTENSION postgis_raster VERSION
 '3.2.2' SCHEMA public
 Executor slow factor: 6.6738 (66.738 ms to fetch full version)
 Upgrading from postgis 3.2.2
 Running before-upgrade-script raster/test/regress/hooks/hook-before-
 upgrade-raster.sql
 Running before-upgrade-script regress/hooks/hook-before-upgrade.sql
 Upgrading PostGIS in 'postgis_reg' using: ALTER EXTENSION postgis UPDATE
 TO '3.5.0dev'
  failed (Error encountered updating EXTENSION POSTGIS:
 /tmp/pgis_reg/regress_log)
 -----------------------------------------------------------------------------
 NOTICE:  schema "public" already exists, skipping
 CREATE SCHEMA
 CREATE EXTENSION
 CREATE EXTENSION
 NOTICE:  schema "public" already exists, skipping
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding SRID constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding scale-X constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding scale-Y constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding blocksize-X constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding blocksize-Y constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding alignment constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding number of bands constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding pixel type constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding nodata value constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding out-of-database constraint
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:16: NOTICE:
 Adding maximum extent constraint
  addrasterconstraints
 ----------------------
  t
 (1 row)

 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:33: NOTICE:
 Adding coverage tile constraint required for regular blocking
 psql:raster/test/regress/hooks/hook-before-upgrade-raster.sql:33: NOTICE:
 Adding spatially unique constraint required for regular blocking
  addrasterconstraints
 ----------------------
  t
 (1 row)

 NOTICE:  schema "public" already exists, skipping
 WARNING:  Deprecated function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) left
 behind: cannot drop function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) because
 other objects depend on it
 DETAIL:  view upgrade_view_test_dwithin depends on function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision)
 HINT:  Replace the view changing all occurrences of
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) in its
 definition with st_dwithin and upgrade again
 ERROR:  Attempting to rename replaced function st_dwithin(text, text,
 float8) got function st_dwithin_deprecated_by_postgis_300(text, text,
 double precision) already exists in schema "public" (42723)
 }}}
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5486#comment:4>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.