[SCM] PostGIS branch master updated. 3.4.0rc1-1005-g4e82dc50d

git at osgeo.org git at osgeo.org
Sun Mar 10 18:48:02 PDT 2024


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "PostGIS".

The branch, master has been updated
       via  4e82dc50db504c75140f0473e7827c14abb05c6d (commit)
      from  f49fa42f059fb01c603125e2fdfceb1eec61fc05 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4e82dc50db504c75140f0473e7827c14abb05c6d
Author: Regina Obe <lr at pcorp.us>
Date:   Sun Mar 10 21:42:43 2024 -0400

    Get rid of no longer
    used function sphere_signed_area
    
    Triggering errors on some bots that treat warnings as errors
    
    References #5671 for PostGIS 3.5.0

diff --git a/liblwgeom/lwgeodetic.c b/liblwgeom/lwgeodetic.c
index 689d4c070..b4068e1a8 100644
--- a/liblwgeom/lwgeodetic.c
+++ b/liblwgeom/lwgeodetic.c
@@ -728,44 +728,6 @@ sphere_angle(const GEOGRAPHIC_POINT *a, const GEOGRAPHIC_POINT *b,  const GEOGRA
 	return sphere_distance_cartesian(&normal1, &normal2);
 }
 
-/**
-* Computes the spherical area of a triangle. If C is to the left of A/B,
-* the area is negative. If C is to the right of A/B, the area is positive.
-*
-* @param a The first triangle vertex.
-* @param b The second triangle vertex.
-* @param c The last triangle vertex.
-* @return the signed area in radians.
-*/
-static double
-sphere_signed_area(const GEOGRAPHIC_POINT *a, const GEOGRAPHIC_POINT *b, const GEOGRAPHIC_POINT *c)
-{
-	double angle_a, angle_b, angle_c;
-	double area_radians = 0.0;
-	int side;
-	GEOGRAPHIC_EDGE e;
-
-	angle_a = sphere_angle(b,a,c);
-	angle_b = sphere_angle(a,b,c);
-	angle_c = sphere_angle(b,c,a);
-
-	area_radians = angle_a + angle_b + angle_c - M_PI;
-
-	/* What's the direction of the B/C edge? */
-	e.start = *a;
-	e.end = *b;
-	side = edge_point_side(&e, c);
-
-	/* Co-linear points implies no area */
-	if ( side == 0 )
-		return 0.0;
-
-	/* Add the sign to the area */
-	return side * area_radians;
-}
-
-
-
 /**
 * Returns true if the point p is on the great circle plane.
 * Forms the scalar triple product of A,B,p and if the volume of the

-----------------------------------------------------------------------

Summary of changes:
 liblwgeom/lwgeodetic.c | 38 --------------------------------------
 1 file changed, 38 deletions(-)


hooks/post-receive
-- 
PostGIS


More information about the postgis-tickets mailing list