<div dir="ltr">Jonas, <div><br></div><div>big thanks - some of those issues, I've fixed somewhere else, those slipped through my eyes or I did it wrong</div><div><br></div><div>can you please make pull request and merge? </div><div><br></div><div>J</div></div><br><div class="gmail_quote"><div dir="ltr">čt 18. 8. 2016 v 21:46 odesílatel Jonas Eberle <<a href="mailto:jonas.eberle@gmx.de">jonas.eberle@gmx.de</a>> napsal:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">Hi all, </div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">I discovered some issues when testing the current master repository: </div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">1) Python error (no such file or directory because working directory has been cleaned up already before) when storing output data as reference with synchronous execution. As a solution I added the variable "async" to Process and extended the if clause in line 244 (app/Process.py): </div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><a href="https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-bddcbbd3f8d8f4182a33f03a1f9a847dR245" target="_blank">https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-bddcbbd3f8d8f4182a33f03a1f9a847dR245</a></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">2) Output url in inout/storage.py is not a combination of "url" and "outputurl", only "outputurl" from configuration is used: </div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><a href="https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R76" target="_blank">https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R76</a></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">3) The calculation of available space on disk was wrong, for Linux systems the method "get_free_space" delivers the number of free blocks (inout/storage.py)</div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><a href="https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R87" target="_blank">https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R87</a></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">4) The output format class has no method "get_extension" (inout/storage.py), thus I used just the extension attribute: </div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><a href="https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R98" target="_blank">https://github.com/jonas-eberle/pywps/commit/51338260674b7271246cc617ff2c37482ec86080#diff-12acb511d79bad7767468cd036926743R98</a></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">Best regards,</div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:#000000">Jonas</div></div></div>_______________________________________________<br>
pywps-dev mailing list<br>
<a href="mailto:pywps-dev@lists.osgeo.org" target="_blank">pywps-dev@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/pywps-dev" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/pywps-dev</a></blockquote></div>