<div dir="ltr">Hi Jorge,<div><br></div><div>thank you for your effort, more from my side lower</div><div><br></div><div>Generic feeling: this should be documented step and we as PSC should vote on this and put the decision as official RFC, see <a href="http://pywps.org/development/rfcs/">http://pywps.org/development/rfcs/</a> </div><div><br><div class="gmail_quote"><div dir="ltr">po 19. 9. 2016 v 4:00 odesílatel Mendes de Jesus, Jorge <<a href="mailto:jorge.mendesdejesus@wur.nl">jorge.mendesdejesus@wur.nl</a>> napsal:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi to all<br>
<br>
<br>
I am looking at adding the copyright and authorship to the pywps code (headers on python code). I am currently working on my branch [0] and Tom suggested that I send an email for consensus on the topics bellow<br>
<br>
<br>
1) Adding GLP for pywps 3.2 and MIT for pywps4<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On the branch pywps-3.2 ( is it also necessary on branch pywps-3.2.3 ???) I have added the generic GLP license [1] while on pywps4 the generic MIT [2]. There was already consensus that we have to jump from GLP to MIT.<br></blockquote><div><br></div><div>We are not going to change history - we shall put it to 3.2 and make new release (3.2.4) with the headers fixed</div><div> </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Aside from license changes from GLP to MIT, also there is a change of headers I included the author name on GLP (also see point 2) and then on the MIT I only have a generic "pywps project steering committee".<br>
<br>
<br>
eg GLP:<br>
<br>
<br>
# Author: Jachym Cepicky<br>
# <a href="http://les-ejk.cz" rel="noreferrer" target="_blank">http://les-ejk.cz</a><br>
# License:<br>
#<br>
# Web Processing Service implementation<br>
# Copyright (C) 2006 Jachym Cepicky<br>
<br>
e.g MIT<br>
# Copyright (C) 2014-2016 PyWPS Development Team, represented by<br>
# PyWPS Project Steering Committee<br>
<br>
Is this ok ??? Are people happy witih it ??? Jachym ??? This was more or less the headers used in one files<br></blockquote><div><br></div><div>+1 from removing my name from everywhere, PSC is now *the* decision body</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
2) Authorship<br>
<br>
<br>
I have looked at the code of pywps-4 code and in some files I have the authors name: eg: Alex Morega, when ever I found author information I have added as:<br>
__author__ = "Alex Morega"<br></blockquote><div><span style="line-height:1.5"> </span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I like it since it is more pythonic, does anyone objects this pythonic author naming and header structure [3] ???<br></blockquote><div><br></div><div>Authors may change in the time. I would personally remove __author__ from the header. If you want to know who did this, git blame will give you more correct answer imho</div><div><span style="line-height:1.5"> </span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
3) Pywps 4.0 author claim (next weekend)<br><br>
I will set up a table with file name and authors, for people to comment and claim ownership. I am more or less assuming that if you haven't indicate your name in the code than the code was mainly done by Jachym.<br></blockquote><div><br></div><div>:-) As I'm writing more upper, I do not think, __author__ is relevant info - in some projects, there can be less then 5% of the original code done by the __author__</div><div><span style="line-height:1.5"> </span></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
4) I have added some indication on XML/HTML/Javascript what license is being used, I was wondering if this is also necessary for templates and other text files ???<br></blockquote><div><br></div><div>We (me and Tom) agreed, that the docs could be creative commons, other files (templates, ...), if part of the code, should have license info too</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
5) I will pass all code in flake8 and fix it<br></blockquote><div><span style="line-height:1.5"><br></span></div><div><span style="line-height:1.5">+1</span></div><div><span style="line-height:1.5"> </span></div><div><span style="line-height:1.5">Thank you!</span></div><div><span style="line-height:1.5"><br></span></div><div><span style="line-height:1.5">J</span></div></div></div></div>