<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Jan,<div class=""><br class=""></div><div class="">Late and short response.</div><div class=""><br class=""></div><div class="">2) using assert in tests seems to be fine … but not for regular code.</div><div class=""><br class=""></div><div class="">1) I can’t say about subprocess calls …I just followed the notes in the python docu:</div><div class=""><a href="https://docs.python.org/3.5/library/subprocess.html" class="">https://docs.python.org/3.5/library/subprocess.html</a></div><div class=""><br class=""></div><div class="">… like not using "shell=True”</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Carsten</div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 22 Jan 2019, at 5:26 pm, Jan Pišl <<a href="mailto:janjanpisl@gmail.com" class="">janjanpisl@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class="">Hi all!<div class=""><br class=""></div><div class="">I am finalizing my pull request [1] that implements database storage for output data from PyWPS processes. The pull request does not pass the Codacy/PR Quality Review check. I have fixed everything I could but there are some issues [2] I am not sure how to tackle, so I want ask you all what you think:</div><div class=""><br class=""></div><div class="">1) Using run and call modules that might have some security implications</div><div class=""><br class=""></div><div class="">Can I use those modules or do I need to replace them? </div><div class=""><br class=""></div><div class="">2) Using "assert" in tests</div><div class=""><br class=""></div><div class="">Is that ok or should I change that? If so, change to what?</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Thank you for any help or advice!</div><div class=""><br class=""></div><div class="">Kind regards,</div><div class=""><br class=""></div><div class="">Jan Pisl</div><div class=""><br class=""></div><div class="">[1]<a href="https://github.com/geopython/pywps/pulls" class=""> https://github.com/geopython/pywps/pulls</a></div><div class="">[2] <a href="https://app.codacy.com/app/cehbrecht/pywps/pullRequest?prid=2042872" class="">https://app.codacy.com/app/cehbrecht/pywps/pullRequest?prid=2042872</a></div></div></div></div></div>
_______________________________________________<br class="">pywps-dev mailing list<br class=""><a href="mailto:pywps-dev@lists.osgeo.org" class="">pywps-dev@lists.osgeo.org</a><br class="">https://lists.osgeo.org/mailman/listinfo/pywps-dev</div></blockquote></div><br class=""></div></body></html>