[QGIS Commit] [qgis/QGIS] 690e7b: Remove include of QtGui in favor of individual inc...

GitHub noreply at github.com
Wed Mar 26 07:45:19 PDT 2014


  Branch: refs/heads/master
  Home:   https://github.com/qgis/QGIS
  Commit: 690e7b096d08672452d8b6918bea7c7280da0c0b
      https://github.com/qgis/QGIS/commit/690e7b096d08672452d8b6918bea7c7280da0c0b
  Author: Carl Simonson <simonsonc at gmail.com>
  Date:   2014-03-16 (Sun, 16 Mar 2014)

  Changed paths:
    M src/app/composer/qgsatlascompositionwidget.cpp
    M src/app/composer/qgscomposer.cpp
    M src/app/composer/qgscomposer.h
    M src/app/qgsattributetabledialog.cpp
    M src/app/qgsundowidget.h
    M src/core/composer/qgscomposereffect.h
    M src/core/composer/qgscomposerlabel.cpp
    M src/core/composer/qgscomposerlegendstyle.cpp
    M src/core/composer/qgscomposermousehandles.cpp
    M src/core/composer/qgscomposertable.cpp
    M src/core/composer/qgspaperitem.cpp
    M src/gui/attributetable/qgsattributetablemodel.cpp
    M src/gui/qgscomposerview.cpp
    M src/gui/symbology-ng/characterwidget.cpp

  Log Message:
  -----------
  Remove include of QtGui in favor of individual includes

The reason for removing instances of "#include <QtGui>" is twofold:

1) Including it will probably include more than is actually needed. Plus,
   it hide what is actually needed, especially if in a header

2) Qt 5 splits Gui into Gui and Widgets, so being explict about what is
   needed gets around this problem


  Commit: f8a558a680207c4b5ee62d2c3af6a712dee74fcd
      https://github.com/qgis/QGIS/commit/f8a558a680207c4b5ee62d2c3af6a712dee74fcd
  Author: Martin Dobias <wonder.sk at gmail.com>
  Date:   2014-03-26 (Wed, 26 Mar 2014)

  Changed paths:
    M src/app/composer/qgsatlascompositionwidget.cpp
    M src/app/composer/qgscomposer.cpp
    M src/app/composer/qgscomposer.h
    M src/app/qgsattributetabledialog.cpp
    M src/app/qgsundowidget.h
    M src/core/composer/qgscomposereffect.h
    M src/core/composer/qgscomposerlabel.cpp
    M src/core/composer/qgscomposerlegendstyle.cpp
    M src/core/composer/qgscomposermousehandles.cpp
    M src/core/composer/qgscomposertable.cpp
    M src/core/composer/qgspaperitem.cpp
    M src/gui/attributetable/qgsattributetablemodel.cpp
    M src/gui/qgscomposerview.cpp
    M src/gui/symbology-ng/characterwidget.cpp

  Log Message:
  -----------
  Merge pull request #1245 from simonsonc/remove-qtgui

Remove include of QtGui in favor of individual includes


Compare: https://github.com/qgis/QGIS/compare/d0c93b94b2e7...f8a558a68020


More information about the QGIS-commit mailing list