<div dir="ltr">Hi,<br><div><br></div><div>Yves, in that case you assume the PR is good enough and ready to merge, which is not the context Anita and Alexandre are referring to.<br></div><div><br></div><div>Personally, I prefer to add comments and let
the contributor fix the issues rather than pushing changes to his branch. This can indeed look intrusive, reason why I applied it to few people.
BUT there are cases where pushing changes is more a help than a bother:</div><div>-
for people facing a conflict that cannot be resolved through the web
interface (like Anita) or do not know git, it helps to move forward. I
prefer keeping all in the single PR rather than opening a new PR with a
loss of comments/suggestion history and a waste of time for everybody.</div><div>- when the PR seems abandoned: no reply/modification applied for weeks from the contributor. Reason why, Yves, I pushed changes to your PR two days ago. Sorry if ever that bothered you but I thought it would help to speed the merge (and did not know your position on this process).</div><div></div><div>Another (less intrusive?) option for the latter case can be to PR against the branch of the contributor and hope he merges it.</div><div></div><div><br></div><div>About some topics discussed in this thread, I'm less enthusiastic with what I seem to understand.</div><div>I personally really prefer to merge a clean PR without issues (and sorry if ever I bothered some with all my (nit-?)picking), than letting issues I'm aware of being merged and hope that someone else (who?) will later treat them (when?). And if those issues are not fixed before release, what about translators workload? Do we ask them to translate the doc as is and if ever the issue is fixed, to translate those strings again? Or do we consider that once a doc is released, we do not touch it again (in which case what about the issues we let pass in the PR)?</div><div>As said, maybe I misunderstand the topic.<br></div><div></div><div><br></div><div>Regards,</div><div>Harrissou</div><div><br></div><div class="gmail_quote"><div dir="ltr">Le jeu. 20 sept. 2018 à 10:00, Yves Jacolin <<a href="mailto:yjacolin@free.fr">yjacolin@free.fr</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="m_-4449964412710261449moz-cite-prefix">Le 20/09/2018 à 09:40, Anita Graser a
écrit :<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div style="font-size:small"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Sep 19, 2018 at 3:50 PM Yves Jacolin
<<a href="mailto:yjacolin@free.fr" target="_blank">yjacolin@free.fr</a>>
wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Finally, about
pushing some fix in a branch of other contributor: I think
this shouldn't be done. I see a branch as a personal work
and pushing a commit, quiet <span id="m_-4449964412710261449m_-1680214509407792307result_box" class="m_-4449964412710261449m_-1680214509407792307short_text" lang="en"><span>invasive</span></span>.
Personally, I commit with amend flag then "push force"
most of the time in my branch.<br>
</div>
</blockquote>
<div><br>
</div>
<div>
<div style="font-size:small">As
someone who has only used the web interface to contribute
to documentation, I would strongly prefer it if reviewers
would fix directly in my branch. At least I didn't see any
ways on the web to use amend flag to incorporate the
proposed changes. It would certainly speed up things.</div>
<div style="font-size:small"><br>
</div>
<div style="font-size:small">Regards,</div>
</div>
</div>
</div>
</blockquote>
<div class="gmail_quote">
<div>
<div style="font-size:small">Anita,<br>
<br>
You can do with the web interface but when you merge the PR. I
added a screenshot. Squashing commit is a good practice to
have a clean commit list.<br>
<br>
Y.<br>
</div>
</div>
</div>
<pre class="m_-4449964412710261449moz-signature" cols="72">--
<a class="m_-4449964412710261449moz-txt-link-freetext" href="http://yjacolin.gloobe.org" target="_blank">http://yjacolin.gloobe.org</a></pre>
</div>
_______________________________________________<br>
Qgis-community-team mailing list for organizing community resources such as documentation, translation etc..<br>
<a href="mailto:Qgis-community-team@lists.osgeo.org" target="_blank">Qgis-community-team@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/qgis-community-team" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/qgis-community-team</a></blockquote></div></div>