<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'><div style="text-align: left;">Hi Martin:<br><br>I´m working in fixing the dependency introduced by the files in dbutilities of core<br>what do you think about this organization of files in dbutilities:<br><br>qgsurimanager will be deprecated and qgsdatasourceuri will be used<br>qgsconnectionmanager has no extra dependencies and could be kept in core/dbutilities<br>qgsconnection has no extra dependencies and could be kept in core/dbutilities<br>qgsdatabaseconnectionbase is used as an interface for (qgspostgresdatabaseconnection and qgsogrdatabaseconnection) has no extra<br> dependencies and could be kept in core/dbutilities<br>qgsgeomcolumntypethread and qgspostgresdatabaseconnection are postgres specific (not really sure) if they are moved to providers<br> then I need to add a dependency in app to postgres provider<br>qgsogrdatabaseconnection is ogr specific, same case that the above one<br><br>Regards <br><br>Godofredo Contreras<br><br><br></div><br><br><br><hr id="stopSpelling">> Date: Wed, 24 Oct 2007 14:03:05 +0200<br>> From: wonder.sk@gmail.com<br>> To: frdcn@hotmail.com<br>> Subject: Re: [Qgis-developer] [QGIS Commit] SVN [godofredo] r7284 - branches/ogr-plugin-branch/src/app<br>> CC: tutey@o2.pl; qgis-developer@lists.qgis.org<br>> <br>> Hi Godofredo,<br>> <br>> when briefly looking at your changes I have some notes:<br>> - it seems that QgsURIManager class does pretty much the same as<br>> QgsDataSourceURI class which is already a part of core library<br>> - you've introduced postresql dependency to core library - this is not<br>> a good thing. One solution could be to make this dependency optional,<br>> however I would prefer to move all postgres-related code to provider<br>> or some other, more appropriate place.<br>> <br>> Bye<br>> Martin<br>> <br>> On 10/23/07, godofredo contreras <frdcn@hotmail.com> wrote:<br>> ><br>> > Hi:<br>> ><br>> > This change was to add the ability to create mysql, oracle and postgres<br>> > vector layers<br>> > via ogr provider, the other changes were in the "add postgis layer dialog"<br>> > that now<br>> > support different kinds of connections in addition to postgres. The new<br>> > classes in<br>> > core/dbutilities are used to separate connection management from the dialogs<br>> > and<br>> > that will be used to update SPIT to work with mysql, and oracle.<br>> ><br>> > There are some plans to support layer creation, and Tim suggested to work a<br>> > little<br>> > with QgsVectorWriter to support some kind of export functionality, but I<br>> > think this will<br>> > be until second stage (once ogr spatial database layer creation and spit<br>> > will be working ).<br>> ><br>> > Regars<br>> ><br>> > Godofredo Contreras<br>> ><br><br /><hr />Windows Live Hotmail and Microsoft Office Outlook – together at last. <a href='http://office.microsoft.com/en-us/outlook/HA102225181033.aspx?pid=CL100626971033' target='_new'>Get it now!</a></body>
</html>