OK<br><br><div class="gmail_quote">2009/1/10 Tim Sutton <span dir="ltr"><<a href="mailto:tim@linfiniti.com">tim@linfiniti.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi<br>
8<-------snip--------------<br>
<div class="Ih2E3d"><br>
><br>
> OK, I will attach the patch to ticket #1482 in a few days.<br>
> Does my proposition in the ticket respect the coding standards ?<br>
<br>
</div>We dont use 'get' get prefix for accessors, so they should be called:<br>
<br>
const QgsFeatureIds?& deletedFeaturesIds() const<br>
const QgsFeatureList?& addedFeatures() const<br>
const QgsGeometryMap?& changedGeometries() const</blockquote><div><br>Can I inline the methods or not ?<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
Also dont forget the new methods should be added to the corresponding<br>
sip file so that they appear in python bindings!</blockquote><div><br>OK. Is there only one file to change python/core/sipcoreQgsVectorLayer.cpp ?<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
Finally, when you add methods, you should include a doxygen note to<br>
indicate the method is new to QGIS 1.1 e.g.<br>
<br>
/* Accessor for the list of features pending deletion when the layer is<br>
next saved.<br>
* @note this method was added in QGIS 1.1<br>
* @return const QgsFeatureIds containing the features to be deleted.<br>
*/</blockquote><div><br>Right.<br><br>Finally, to make the patch, is it OK with the following command : diff -Naux original modified > original.patch ?<br>Is there a special policy for the names of the patch files to attach to the trac ticket ?<br>
<br>Best regards and sorry for all this boring questions,<br><br>Olivier<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
<br>
Best regards<br>
<br>
Tim<br>
<br>
><br>
> Regards,<br>
><br>
> Olivier<br>
><br>
<br>
8<-------snip--------------<br>
<font color="#888888"><br>
<br>
<br>
<br>
<br>
--<br>
</font><div><div></div><div class="Wj3C7c">Tim Sutton - QGIS Project Steering Committee Member (Release Manager)<br>
==============================================<br>
Visit <a href="http://linfiniti.com" target="_blank">http://linfiniti.com</a> to find out about:<br>
* QGIS programming services<br>
* Mapserver and PostGIS based hosting plans<br>
* FOSS Consulting & Support Services<br>
Skype: timlinux Irc: timlinux on #qgis at <a href="http://freenode.net" target="_blank">freenode.net</a><br>
==============================================<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Dr. Olivier Tournaire<br>MATIS - Institut Géographique National<br>73, Ave de Paris<br>94165 St Mandé cedex, France<br><br>tel: (+33) 1 43 98 80 00 - 71 25<br>
fax: (+33) 1 43 98 85 81<br>