<div class="gmail_quote">2011/1/23 Alex Mandel <span dir="ltr"><<a href="mailto:tech_dev@wildintellect.com">tech_dev@wildintellect.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5">On 01/22/2011 03:26 PM, Alessandro Pasotti wrote:<br>
> 2011/1/22 Gary Sherman <<a href="mailto:gsherman@geoapt.com">gsherman@geoapt.com</a>><br>
><br>
>> On 1/22/11 8:57 AM, Alessandro Pasotti wrote:<br>
>><br>
>>> 2011/1/22 Gary Sherman <<a href="mailto:gsherman@geoapt.com">gsherman@geoapt.com</a> <mailto:<a href="mailto:gsherman@geoapt.com">gsherman@geoapt.com</a>>><br>
>>><br>
>>><br>
>>> On 1/22/11 1:25 AM, Alessandro Pasotti wrote:<br>
>>><br>
>>> 2011/1/22 Paolo Cavallini <<a href="mailto:cavallini@faunalia.it">cavallini@faunalia.it</a><br>
>>> <mailto:<a href="mailto:cavallini@faunalia.it">cavallini@faunalia.it</a>><br>
>>> <mailto:<a href="mailto:cavallini@faunalia.it">cavallini@faunalia.it</a> <mailto:<a href="mailto:cavallini@faunalia.it">cavallini@faunalia.it</a>>>><br>
>>><br>
>>><br>
>>><br>
>>> Il giorno ven, 21/01/2011 alle 19.37 +0100, Alessandro<br>
>>> Pasotti ha<br>
>>> scritto:<br>
>>><br>
>>> > The missing piece was the authentication bridge with OSGEO.<br>
>>><br>
>>> AFAIK this is now working. If so, what prevents us from setting<br>
>>> everything in place?<br>
>>> All the best.<br>
>>><br>
>>><br>
>>><br>
>>> I'was able to login with my osgeo credentials but I couldn't<br>
>>> upload a<br>
>>> plugin: it fails with permission denied on the folder where the<br>
>>> plugin<br>
>>> files should reside.<br>
>>><br>
>>> Somebody with root access to the server should fix it.<br>
>>><br>
>>> [Errno 13] Permission denied:<br>
>>> '********************/qgis/static/packages'<br>
>>><br>
>>> The validation of plugin packages doesn't work properly for all<br>
>>> packages. My plugin that uploads and validates find on the "old" repo<br>
>>> (<a href="http://pyqgis.org" target="_blank">pyqgis.org</a> <<a href="http://pyqgis.org" target="_blank">http://pyqgis.org</a>>) fails on the new site:<br>
>>><br>
>>><br>
>>> File upload must be a valid QGIS Python plugin compressed archive.<br>
>>> Cannot find __init__.py in the compressed package: this does not<br>
>>> seems a valid plugin (I searched for pluginbuilder/Makefile__init__.py)<br>
>>><br>
>>> Looks like it is munging things together that shouldn't be....<br>
>>><br>
>>><br>
>>><br>
><br>
> Your plugin loads without errors on my dev environment (I cannot reproduce<br>
> the issue).<br>
><br>
> I will try on the server tomorrow.<br>
><br>
> In the meantime, I've opened a project on redmine for the django site.<br>
><br>
<br>
</div></div>It appears that relying on the 1st item in the zip to always be<br>
packagename.zip just isn't 100% reliable. My metaedit plugin fails that<br>
test in python but is clearly formatted correctly when extracted or<br>
downloaded by qgis. I did test in python by hand too and metaedit/ isn't<br>
in the namelist at all for some reason even though the folder is there<br>
when the package is extracted.<br>
<br>
Here are some possible ways to change the validator<br>
namelist[0].split('/') to grab whatever is before the /<br>
or package.split('.') to grab the name of the zip minus the ext<br>
- There are several other ways to do this in python with the os and path<br>
modules, or slicing. The nice part about package.split is that you could<br>
save both the packagename and ext to test if the ext is zip<br>
<br>
packagename,ext = package.split('.')<br>
<br></blockquote><div><br></div><div>Thanks Alex, </div><div><br></div><div>I agree, but this would be a different check:</div><div><br></div><div>the intention was to check that *inside* the zip there is a folder with name = package_name, non to check that the zip file is named package_name.</div>
<div><br></div><div>Perhaps I misunderstood the specs, but I guess that the plugin zip file could be whatever name we like (for example I name my zipfiles with the version postfix such as QuickWKT_0.1.zip, QuickWKT_0.2.zip etc. etc.), what I wanted to check is that inside the zip there is a folder named package_name (in this example "QuickWKT").</div>
<div><br></div><div><br></div><div>I changed the line to</div><div><br></div><div><div><br></div></div><div><div> # Checks that package_name/__init__.py exists</div><div> namelist = zip.namelist()</div><div>
try:</div><div> package_name = namelist[0][:namelist[0].index('/')]</div><div> except:</div><div> raise ValidationError( _("Cannot find a folder inside the compressed package: this does not seems a valid plugin") )</div>
</div><div><br></div><div><br></div><div><br></div><div>this should make it more robust</div><div><br></div><div> </div></div>-- <br>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it">www.itopen.it</a><br>