<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Radim,<br>
<br>
I just finished the work thanks to Jef's debugging ability!<br>
<br>
Here is the pull request<br>
<a class="moz-txt-link-freetext" href="https://github.com/qgis/Quantum-GIS/pull/421">https://github.com/qgis/Quantum-GIS/pull/421</a><br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
The identify method now returns directly the IdentifyResults instead
of using a private attribute.<br>
Also, IdentifyResult is now a single struct (no RasterResult and
VectorResult)<br>
<br>
Everything compiles fine and I tested it.<br>
However, could you check that everything is ok regarding to the
rasterChanged?<br>
<br>
Also, could you take care of accepting the pull request?<br>
<br>
Thanks,<br>
<br>
Denis<br>
<br>
<br>
<div class="moz-cite-prefix">On 02/07/2013 11:24 AM, Radim Blazek
wrote:<br>
</div>
<blockquote
cite="mid:CAEMrtYqDkFCvf2Rqo-qW=SZccmE-f_JPU5j0Rg9dekMGK4qZFg@mail.gmail.com"
type="cite">
<pre wrap="">Hi,
sorry, I do not use IRC usually.
I would like to return to work in identify tool areas next week:
- copy feature from context menu
- better tree hierarchy for rasters
- propagate errors to user - probably just error messages as texts in tree
- instead of all that signals on format change just listen in action
and then call QgsMapToolIdentify and dialog functions
Please let me know when you finish your work in identify tool so that
we avoid conflicts.
Radim
On Thu, Feb 7, 2013 at 10:04 AM, Denis Rouzaud <a class="moz-txt-link-rfc2396E" href="mailto:denis.rouzaud@gmail.com"><denis.rouzaud@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Radim,
I have already merged the changes to return directly the results.
I am currently making a single struct for the results. I have a problem with
python files, an error in compilation I am trying to solve for some time now
without any success...
Would you have some time to give me hand?
Are you on IRC?
Thanks
Denis
On 02/06/2013 05:07 PM, Radim Blazek wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">
Also, your changes to the raster result structure made me think that we
could use a single struct for both vector and raster result.
It might be easier to look into the results.
Any opinion on this? Nathan?
</pre>
</blockquote>
<pre wrap="">
I believe, that It would be better to pass results to the dialog in
the original hierarchical structure instead of splitting them to
individual results and then reconstruct the tree searching for the
layer it should go into. For rasters the logical structure may vary
form one level for raster values (I would prefer to put band values
directly into layer item instead of adding additional level "feature")
to four levels for WMS with layer-sublayer-featuretype-feature.
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
Maybe some parts of QgsMapToolIdentify::identifyVectorLayer and
QgsMapToolIdentify::identifyRasterLayer, those related to creation the
tree in dialog should better be moved to QgsIdentifyResultsDialog?
I'll possibly add QgsRasterIdentifyResult and the dialog could work
directly with that or to use current QList<QVariant> returned from
raster identify().
</pre>
</blockquote>
<pre wrap="">
yes,
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>