Hi Olivier<br><br>+1 for me, this looks much better. Thanks for this work.<br><br><div class="gmail_quote">2013/2/12 Olivier Dalang <span dir="ltr"><<a href="mailto:olivier.dalang@gmail.com" target="_blank">olivier.dalang@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Hi !</div><div><br></div><div>I've made a pull request that induces some changes in the Composer's items GUI.</div>
<div>If you are interested, please have a look (feedback is of course welcome) : </div><div><br>
</div><div><a href="https://github.com/qgis/Quantum-GIS/pull/426" target="_blank">https://github.com/qgis/Quantum-GIS/pull/426</a></div><div><br></div><div>Best regards,</div><div><br></div><div>Olivier</div><div><br></div>
<div><br></div>
<div>####################################################</div><div><br></div><div><h3 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:18px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
The differences</h3><h4 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:16px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">QToolBox replaced by QCollapsibleGroupBox(es).</h4>
<p style="margin:0px 0px 15px;padding:0px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><i style="margin:0px;padding:0px;border:0px">before</i></p>
<ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
a lot of wasted space</li><li style="margin:0px;padding:0px;border:0px">unpractical (you must toggle back and forth to edit elements on different pages)</li><li style="margin:0px;padding:0px;border:0px">not very good looking (it looks messy and it's hard to distinguigh from QDockWindowss)</li>
</ul><p style="margin:15px 0px;padding:0px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><i style="margin:0px;padding:0px;border:0px">after</i></p>
<ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
QgsCollapsibleGroupBoxes look great and provide a nice outline of all features when folded</li><li style="margin:0px;padding:0px;border:0px">Easier to adapt to your needs and screen size</li></ul><h4 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:16px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
QToolBox replaced by QCollapsibleGroupBox(es).</h4><ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)">
<li style="margin:0px;padding:0px;border:0px">so you can dynamically reposition/resize the items without having to open a modal dialog.</li><li style="margin:0px;padding:0px;border:0px">also provides a nice feedback on element's position</li>
</ul><h4 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:16px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">Harmonisation and optimisation of widget layouts</h4>
<ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
most of the widgets had uneven spacing (looked a bit sketchy)</li><li style="margin:0px;padding:0px;border:0px">some widgets where uselessly big</li><li style="margin:0px;padding:0px;border:0px">better hiearchy and grouping of similar options</li>
</ul><h4 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:16px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">Duplicate/Ambigious/Unclear functionalities</h4>
<ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
QgsComposerShape had duplicate implemtation of frame and background</li></ul><h3 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:18px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
Changes</h3><p style="margin:0px 0px 15px;padding:0px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)">The work was mainly done in the .ui files, but some classes are a little more modified :</p>
<ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
QgsComposerShape (clean duplicate frame/background implementation)</li><li style="margin:0px;padding:0px;border:0px">QgsItemPositionDialog was merged into QgsComposerItemWidget, which also makes some change</li></ul><h3 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:18px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
Screenshots</h3><p style="margin:0px 0px 15px;padding:0px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)">Here are screenshots of all modified widgets :<br>
<a href="https://www.dropbox.com/sh/gkte3o126doe4ue/YfN_iVxRKx" style="margin:0px;padding:0px;border:0px;color:rgb(65,131,196);text-decoration:initial" target="_blank">https://www.dropbox.com/sh/gkte3o126doe4ue/YfN_iVxRKx</a></p>
<h3 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:18px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
Todo</h3><ul style="margin:15px 0px;padding:0px 0px 0px 30px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251)"><li style="margin:0px;padding:0px;border:0px">
I think it would be nice to integrate the atlas' widget into the composition's widget</li><li style="margin:0px;padding:0px;border:0px">It would be nice if there was a collapse/expand all button (or a shortcut (alt-click ?) to collapse all other QgsCollapsibleBoxes)</li>
<li style="margin:0px;padding:0px;border:0px">Use color buttons wherever possible</li></ul><h3 style="margin:20px 0px 10px;padding:0px;border:0px;font-size:18px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;background-color:rgb(251,251,251)">
So...</h3><p style="margin-top:0px;margin-right:0px;margin-left:0px;padding:0px;border:0px;color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:20px;background-color:rgb(251,251,251);margin-bottom:0px!important">
What do you think ?</p></div><div><br></div><div><br></div>
<br>_______________________________________________<br>
Qgis-developer mailing list<br>
<a href="mailto:Qgis-developer@lists.osgeo.org">Qgis-developer@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
<br></blockquote></div><br>