<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Ivan,<br>
<br>
I updated the plugin with your useful comments. You have a version
0.4 available.<br>
<br>
Regarding the schema tables names, I have filled a pull request here
<a href="https://github.com/2ndQuadrant/audit-trigger/pull/2"> </a><a
href="https://github.com/2ndQuadrant/audit-trigger/pull/2/files">https://github.com/2ndQuadrant/audit-trigger/pull/2/files</a><br>
You can use my branch if you like: <a
href="https://github.com/3nids/audit-trigger/blob/schemasafe/audit.sql">https://github.com/3nids/audit-trigger/blob/schemasafe/audit.sql</a><br>
<br>
I have an issue tracker on github: <a
href="https://github.com/3nids/postgres91plusauditor/issues">https://github.com/3nids/postgres91plusauditor/issues</a><br>
<br>
Thanks a lot for your comments and for your time at testing, it's
really appreciated! I am waiting for these bugs ;)<br>
<br>
Greetings,<br>
<br>
Denis<br>
<br>
<div class="moz-cite-prefix">On 05/22/2013 01:53 PM, Ivan Mincik
wrote:<br>
</div>
<blockquote
cite="mid:CAN8Jn0AWCRj=R6+SJQ1ooKiWRLeRC1X_-KeKcHXbK_4bBg8Y=w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>Hi Denis,<br>
</div>
I have found a problem. The problem was that menu item 'Define
logged action layer' was confusing for me and I was choosing
my PostGIS geometry layer there. I recommend to rename it to
something like 'Choose audit history table' (avoid using
'layer') with some description that the table should be loaded
to QGIS. Now 'search history' windows opens correctly. <br>
<br>
Also I recommend to exclude at least any geometry tables from
'logged action layer chooser' dialog and also exclude 'history
table' from choosing itself from selecbox in 'search history'
window.<br>
<br>
</div>
<div>One more question, how do you activate audit if table
exists in some schema outside of default search_path ? Using <br>
<pre class=""><span class="">SELECT</span> audit<span class="">.</span>audit_table<span class="">(</span><span class="">'<schema>.<table>'</span><span class="">)</span>;
</pre>
<pre class="">is not working for me.
</pre>
</div>
<div><br>
</div>
<div>I have found some other bugs which will be better to submit
in bug tracker. Do you have some ?<br>
</div>
<div>
<div>
<div><br>
<br>
<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> I have
hesitated with creating something like your
approach, but I decided to use something which is
"official". As, the trigger is available on
postgres website, I hope it will last a bit.<br>
</div>
</blockquote>
<div class="h5"><br>
</div>
<div class="h5">I see one big disadvantage with this
Audit trigger implementation which is performance,
if history of all tables is recorded to one huge
table. If you have many changes in one big table it
will affect all other. Moreover I am missing tests
(which of course can be added).<br>
<br>
<br>
</div>
<div class="h5">Thanks,<br>
<br>
</div>
<div class="h5">Ivan<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>