<div dir="ltr">Hi Régis and Michael,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 27, 2013 at 3:53 AM, Larry Shaffer <span dir="ltr"><<a href="mailto:larrys@dakotacarto.com" target="_blank">larrys@dakotacarto.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 27, 2013 at 2:09 AM, kimaidou <span dir="ltr"><<a href="mailto:kimaidou@gmail.com" target="_blank">kimaidou@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi<br><div><div class="gmail_extra"><br><div class="gmail_quote">2013/5/27 HAUBOURG <span dir="ltr"><<a href="mailto:regis.haubourg@eau-adour-garonne.fr" target="_blank">regis.haubourg@eau-adour-garonne.fr</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div link="blue" vlink="purple" lang="FR">
<div>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)">Hi Larry,
<u></u><u></u></span></p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">Putting expression item to the bottom of list, and renaming the entries as follow should be better IMHO, since expression is more advanced:</span>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">“Field types : String, Int, Double” -> “choose Field ( enable map tools)”<u></u><u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">“Edit expression” ->” Calculate value with expression (disable map tool)”<u></u><u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">Does that sound good?</span></p></div></div></blockquote><div><br></div><div>This sounds good to me, as I had the same problem easilly finding the way to choose fields here.<br>
</div><div></div></div></div></div></div></blockquote><div><br></div><div>Switching the order should help. Originally, the button's menu didn't have a field's submenu, and the fields were listed at the bottom of the menu (to allow for an unknown number of entries). That didn't work well for tables with lots of columns, since it often pushed access to expression menu actions off the screen; so I made a submenu. <br>
</div><div><br></div><div>Changing the menu action text to long descriptions, like the proposed one for expression, may lead to 'missing' the entry to the submenu while mousing that far to the right. The text's width will dictate the total width of the menu. This was a problem with the expression string menu entry, which is now truncated.<br>
</div><div> <br></div>I'd prefer to just explain it better in the text below the buttons and in those button's description/tool tip.<br></div></div></div></blockquote><div><br></div><div>I've made improvements today to the QgsDataDefinedButton, along the lines of your suggestions, in commit dd60a34 [0].<br>
<br></div><div>Commit message:<br>Update QgsDataDefinedButton<br>- Add 'Usage info' functions; displays in description and tool tip<br>- Reorganize menu, adding conceptual section titles<br>- Add ability to paste in expression<br>
- Add ability to clear defined expression<br>- Add check for non-matching data field types<br>- Add better truncation of expressions in tool tip and menu<br></div><div><br></div><div>Of note, I added the ability to set custom 'Usage info' for each button, which allowed me to remove the general text "( Define attribute fields to enable labeling map tools )" from below, and include more descriptive, contextual information in the tool tip and description popup:<br>
<br>Usage:<br>In edit mode, layer's relevant labeling map tool is:<br> Defined attribute field -> enabled<br> Defined expression -> disabled<br></div><div><br></div><div>I would appreciate any further feedback on the button's new menu layout. I consider the button's functionality to be ready for release, but there is always room for improvement. :^)<br>
</div><div><br>[0] <a href="https://github.com/qgis/Quantum-GIS/commit/dd60a34fae326fcf28d3415d55140e3488f84d62">https://github.com/qgis/Quantum-GIS/commit/dd60a34fae326fcf28d3415d55140e3488f84d62</a><br><br></div><div>Regards,<br>
<br></div><div>Larry<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div>Regards,<br><br></div><div>Larry<br><br></div><div><br></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div link="blue" vlink="purple" lang="FR"><div><p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US"><u></u><u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">[0]
<a href="https://dl.dropboxusercontent.com/u/72368800/label_dialog.png" target="_blank">https://dl.dropboxusercontent.com/u/72368800/label_dialog.png</a><u></u><u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">All the best<u></u><u></u></span></p>
<p><span style="font-size:11pt;font-family:"Calibri","sans-serif";color:rgb(31,73,125)" lang="EN-US">Régis</span><br></p></div></div></blockquote></div><br><br></div><div class="gmail_extra">
Regards<br></div><div class="gmail_extra">Michael<br></div></div></div>
</blockquote></div><br></div></div>
</blockquote></div><br></div></div>