<div dir="ltr">Hi<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 13, 2014 at 1:59 PM, Tim Sutton <span dir="ltr"><<a href="mailto:lists@linfiniti.com" target="_blank">lists@linfiniti.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi<div class="gmail_extra"><br><br><div class="gmail_quote">
<div><div class="h5">On Mon, Jan 13, 2014 at 11:35 AM, Richard Duivenvoorde <span dir="ltr"><<a href="mailto:rdmailings@duif.net" target="_blank">rdmailings@duif.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div>On 13-01-14 10:18, Matthias Kuhn wrote:<br>
> Some general advice (althogh I'm not sure how exactly that happened) is to<br>
><br>
> For creating a pull request<br>
> ===============<br>
> - always start a feature branch from current master<br>
> - if you are coding a feature branch, don't "merge" anything in<br>
> - before you create a pull request do "git fetch origin" and "git rebase<br>
> origin/master" (given origin is the remote for upstream and not your own<br>
> remote, check your .git/config or do "git remote -v | grep<br>
> <a href="http://github.com/qgis" target="_blank">github.com/qgis</a>")<br>
> - you may do a "git rebase" like in the last line repeatedly without<br>
> doing any damage (as long as the only purpose of your branch is to get<br>
> merged into master)<br>
> - Attention: After a rebase you need to "git push -f". CORE DEVS: IF YOU<br>
> DO THIS ON THE UPSTREAM REPOSITORY YOU WILL BRING CAKE FOR EVERYBODY TO<br>
> THE NEXT HF!<br>
><br>
> For merging a pull request<br>
> ===============<br>
> Option A)<br>
> - click the merge button (Creates a non-fast-forward merge)<br>
><br>
> Option B)<br>
> - Checkout the pull request (See<br>
> <a href="https://gist.github.com/piscisaureus/3342247" target="_blank">https://gist.github.com/piscisaureus/3342247</a>)<br>
> - Test (Also required for option A, obviously)<br>
> - checkout master, "git merge pr/1234"<br>
> - Optional: "git pull --rebase": Creates a fast-forward, no "merge<br>
> commit" is made. Cleaner history, but it is harder to revert the merge.<br>
> - "git push"<br>
><br>
> I hope that I got things right and that somebody finds this useful.<br>
<br>
</div></div>Hi Matthias,<br>
<br>
I think it is VERY usefull. But I also think we should create a<br>
'git'-page in documentation which contains this info.<br>
<br>
I think it would also be helpfull to show the (more general) git<br>
commands for creating a local branch etc.<br>
<br>
I'll try to create a page for that with the information above, and add<br>
some stuff that I think is usefull.<br>
Plz have a look into it when finished.<br></blockquote><div><br></div><div><br></div></div></div><div>Richard this kind of stuff should go in the CODING doc. I have already added some infor on Pull Requests there following our previous to last PSC meeting, and just updated it with Matthias' notes too. I'm just waiting for my internet to allow me to actually push it.....</div>
<div><br></div></div></div></div></blockquote><div><br></div><div>Commit is here:</div><div><br></div><div><a href="https://github.com/qgis/QGIS/commit/e745b2ffa5a6f1a249dedba18eded232857097c7">https://github.com/qgis/QGIS/commit/e745b2ffa5a6f1a249dedba18eded232857097c7</a><br>
</div><div><br></div><div>Regards</div><div><br></div><div>Tim</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div>Regards</div><div><br></div><div>Tim </div><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Regards,<br>
<br>
Richard Duivenvoorde<br>
<div><div><br>
<br>
<br>
<br>
_______________________________________________<br>
Qgis-developer mailing list<br>
<a href="mailto:Qgis-developer@lists.osgeo.org" target="_blank">Qgis-developer@lists.osgeo.org</a><br>
<a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
</div></div></blockquote></div></div><span class=""><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Tim Sutton - QGIS Project Steering Committee Member<br>==============================================<br>
Please do not email me off-list with technical<br>
support questions. Using the lists will gain<br>more exposure for your issues and the knowledge<br>surrounding your issue will be shared with all.<br><br>Irc: timlinux on #qgis at <a href="http://freenode.net" target="_blank">freenode.net</a><br>
==============================================</div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Tim Sutton - QGIS Project Steering Committee Member<br>==============================================<br>Please do not email me off-list with technical<br>
support questions. Using the lists will gain<br>more exposure for your issues and the knowledge<br>surrounding your issue will be shared with all.<br><br>Irc: timlinux on #qgis at <a href="http://freenode.net" target="_blank">freenode.net</a><br>
==============================================</div>
</div></div>