<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 02 Jun 2015, at 18:15, Nathan Woodrow <<a href="mailto:madmanwoo@gmail.com" class="">madmanwoo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm all for strict unit test policy however they need to be able to run on all platforms consistently in order to enforce that correctly. Taking the failing PyQgsAppStartup test on Travis, i just ran it on my Linux setup and it passes fine, yet fails on Travis. I'm skeptical of that test anyway but it does make it hard to fix when it can't be reproduced..<br class=""><div class=""><br class=""></div><div class="">Compare to Traivs I get these two tests failing:</div><div class=""><br class=""></div><div class=""><div class="">The following tests FAILED:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>100 - PyQgsLocalServer (Failed)</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>134 - PyQgsPalLabelingServer (Failed)</div></div></div></div></blockquote><div><br class=""></div><div>Disabling a test is also a legitimate course of action - if the test does not run as expected and there is no reasonable way to see why in python you can tag it as ‘expected failure’ using the expectedFailure decorator. Obviously that should not be the default action when a test fails and should not be used to disable tests in masse, but disabling the test puts travis back into a testable state for other dev while you figure out the reason for the regression.</div><div><br class=""></div><div>Regards</div><div><br class=""></div><div>Tim</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, 2 Jun 2015 at 19:31 Matthias Kuhn <<a href="mailto:matthias@opengis.ch" class="">matthias@opengis.ch</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jürgen<br class="">
<br class="">
On 06/02/2015 09:03 AM, Jürgen E. Fischer wrote:<br class="">
> Hi Nyall,<br class="">
><br class="">
> On Tue, 02. Jun 2015 at 13:34:56 +1000, Nyall Dawson wrote:<br class="">
>> I'd be in favour of a hardline "no breaks allowed" approached. You break<br class="">
>> travis, your commit gets reverted.<br class="">
> -1<br class="">
><br class="">
> A general rule doesn't make sense to me - it depends on the break.<br class="">
> If you break travis, you should fix it.<br class="">
<br class="">
For the record, can you elaborate which types of breaks should not be<br class="">
fixed and/or why certain breaks should be fixed in master instead of in<br class="">
a separate branch/pull request?<br class="">
<br class="">
Regards<br class="">
Matthias<br class="">
_______________________________________________<br class="">
Qgis-developer mailing list<br class="">
<a href="mailto:Qgis-developer@lists.osgeo.org" target="_blank" class="">Qgis-developer@lists.osgeo.org</a><br class="">
<a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank" class="">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br class="">
</blockquote></div>
_______________________________________________<br class="">Qgis-developer mailing list<br class=""><a href="mailto:Qgis-developer@lists.osgeo.org" class="">Qgis-developer@lists.osgeo.org</a><br class="">http://lists.osgeo.org/mailman/listinfo/qgis-developer</div></blockquote></div><br class=""><div apple-content-edited="true" class="">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-align: center;" class=""><span>—</span></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-align: center;" class=""><span><br class=""></span></div><span style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline"><span><img height="66" width="160" apple-inline="yes" id="5241CAFA-AABD-4BAB-8A1C-93C385EBCDF7" apple-width="yes" apple-height="yes" src="cid:62C890D4-3964-4609-BDE6-7536D5FBDD70" class=""></span><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-align: center;" class=""><br class="Apple-interchange-newline"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-align: center;" class="">Tim Sutton</div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-align: center;" class=""><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div style="text-align: center;" class="">Visit <a href="http://kartoza.com" class="">http://kartoza.com</a> to find out about open source:</div><div style="text-align: center;" class=""><br class=""></div><div class=""><div style="text-align: center;" class="">* Desktop GIS programming services</div><div style="text-align: center;" class="">* Geospatial web development</div><div style="text-align: center;" class="">* GIS Training</div><div style="text-align: center;" class="">* Consulting Services</div><div style="text-align: center;" class=""><br class=""></div><div class=""><div style="text-align: center;" class="">Skype: timlinux Irc: timlinux on #qgis at <a href="http://freenode.net" class="">freenode.net</a></div><div style="text-align: center;" class="">Tim is a member of the QGIS Project Steering Committee</div><div style="text-align: center;" class=""><br class=""></div><div style="text-align: center;" class="">Kartoza is a merger between Linfiniti and Afrispatial</div></div></div></div>
</span></div>
<br class=""></div></body></html>