<div dir="ltr"><div><div>Hi Matthias,<br><br></div>you can find my attempt to create pull-request template<br></div>in my fork <a href="https://github.com/alexbruy/QGIS/commits/pr-template">https://github.com/alexbruy/QGIS/commits/pr-template</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-02-20 16:45 GMT+02:00 Matthias Kuhn <span dir="ltr"><<a href="mailto:matthias@opengis.ch" target="_blank">matthias@opengis.ch</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Alexander,<br>
<br>
I recently started to write a CONTRIBUTING.md [1] file which is also<br>
shown when opening a PR. But it's always one click away and I think<br>
moving this to a PR template would be much better.<br>
It will probably reduce the roundtrip if when creating a PR every<br>
contributor is reminded of<br>
<br>
 * Did you run prepare-commit.sh?<br>
 * Have you written a unit test where applicable?<br>
 * Did you create .sip bindings?<br>
 * Did you write API documentation?<br>
 * Is your commit message meaningful?<br>
 * Did you add [needs-docs] or [feature] tags to the commit message and<br>
include enough information for documentors in the commit message?<br>
<br>
Is there more information that should be included?<br>
Would you mind setting up a draft for it?<br>
<br>
Matthias<br>
<br>
[1] <a href="https://github.com/qgis/QGIS/pull/2581" rel="noreferrer" target="_blank">https://github.com/qgis/QGIS/pull/2581</a><br>
<div class="HOEnZb"><div class="h5"><br>
On 02/19/2016 07:45 AM, Alexander Bruy wrote:<br>
> Hi all,<br>
><br>
> recently GitHub introduced templates support for issues and<br>
> pul-request, see [0, 1].<br>
> Maybe we can utilize this functionality in our repos. For example,<br>
> issue template<br>
> can be used for the QEP repository and PR templates for main QGIS repo as<br>
> well as for QGIS-Processing and maybe some other.<br>
><br>
> Opinions?<br>
><br>
> [0] <a href="https://github.com/blog/2111-issue-and-pull-request-templates" rel="noreferrer" target="_blank">https://github.com/blog/2111-issue-and-pull-request-templates</a><br>
> [1] <a href="https://help.github.com/articles/helping-people-contribute-to-your-project/" rel="noreferrer" target="_blank">https://help.github.com/articles/helping-people-contribute-to-your-project/</a><br>
><br>
<br>
--<br>
</div></div><span class="HOEnZb"><font color="#888888">Matthias Kuhn<br>
OPENGIS.ch - <a href="https://www.opengis.ch" rel="noreferrer" target="_blank">https://www.opengis.ch</a><br>
Spatial • (Q)GIS • PostGIS • Open Source<br>
<br>
<br>
</font></span><br>_______________________________________________<br>
Qgis-developer mailing list<br>
<a href="mailto:Qgis-developer@lists.osgeo.org">Qgis-developer@lists.osgeo.org</a><br>
List info: <a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br>
Unsubscribe: <a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman/listinfo/qgis-developer</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Alexander Bruy</div>
</div>