<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /></head><body style='font-size: 10pt; font-family: Verdana,Geneva,sans-serif'>
<p>Hi Even,</p>
<p>Thank you for your thorough review of the situation and the explanation.</p>
<p>I asked the person who reopened this bug to provide more details - which we hopefully get. Otherwise, I suggest we close this issue again.</p>
<p>Andreas</p>
<p>On 2016-06-29 15:45, Even Rouault wrote:</p>
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<div class="pre" style="margin: 0; padding: 0; font-family: monospace">Andreas,<br /><br /> I cannot confirm. But the bug has been reopened without specifying the <br /> operating system, the GDAL version and the exact procedure followed (possibly <br /> with the dataset in case it might make a difference), so it might hit some <br /> particular case.<br /><br /> So here's my setup :<br /> - versions tried : up-to-date versions of QGIS master and 2.14 branch<br /> - OS: Linux<br /> - GDAL >= 2.1<br /><br /> Steps :<br /> 1) Download:<br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shp">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shp</a><br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shx">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shx</a><br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.dbf">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.dbf</a><br /><br /> 2) Open the shapefile in QGIS<br /><br /> 3) Turn on edition mode<br /><br /> 4) Select the feature with EAS_ID = 165 (the one roughly at the middle)<br /><br /> 5) Delete it<br /><br /> 6) Turn off edition mode and confirm saving the changes<br /><br /> 7) Quit QGIS and do "ogrinfo -al poly.shp". You'll see "Feature Count: 9" and <br /> 9 features numeroted without hole from OGRFeature(poly):0 to <br /> OGRFeature(poly):8<br /><br /><br /> Sure, a test could be added to simulate that (looking at <br /> test_provider_shapefile.py it doesn't seem there's one), but there's probably <br /> something we miss here w.r.t. the reporter setup.<br /><br /><br /> On the reverse, to see the effect of *no* repacking, if you do :<br /><br /> 1) Download:<br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shp">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shp</a><br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shx">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.shx</a><br /><a href="http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.dbf">http://svn.osgeo.org/gdal/trunk/autotest/ogr/data/poly.dbf</a><br /><br /> 2) ogrinfo poly.shp -sql "delete from poly where eas_id = 165" -dialect sqlite<br /><br /> 3) ogrinfo -al poly.shp. You'll see "Feature Count: 10" and features numbered <br /> from OGRFeature(poly):0 to OGRFeature(poly):9 with a hole (OGRFeature(poly):8 <br /> missing) --> the shapefile hasn't been repacked (as "expected" from current OGR <br /> behaviour)<br /><br /> Even<br /><br />
<blockquote type="cite" style="padding: 0 0.4em; border-left: #1010ff 2px solid; margin: 0">Hi,<br /><br /> There is (hopefully was) this annoying ESRI Shape Repack issue - see<br /><a href="http://hub.qgis.org/issues/11007">http://hub.qgis.org/issues/11007</a><br /><br /> I see that this bug was re-opened - Antoine SIG claims that it worked in<br /> 2.14.1 and 2.14.2 (Windows) but fails again in 2.14.3. Can someone<br /> confirm? How can that happen? Can a test be added to ensure this doesn't<br /> fail again?<br /><br /> How about 2.16? Does it work there if it is built with GDAL 2.x?<br /><br /> I can't reproduce, since I don't have another GIS besides QGIS to check.<br /><br /><br /> Thanks,<br /><br /> Andreas</blockquote>
</div>
</blockquote>
<p> </p>
<div> </div>
</body></html>