<div dir="ltr">Hi Luigi and Paolo,<div><br></div><div>           I corrected the problems you pointed out with AequilibraE and re-uploaded it.</div><div><br></div><div>Luigi's concern with malicious code is a very valid one, and I would actually appreciate to have a manner to have it checked. However, I would appreciate if we could find a solution that does not prevent us from having plugins that are compiled.</div><div><br></div><div>As Luigi pointed out, the code is written in Cython to increase performance of the software, but it is still 5.5x slower than the proprietary software that I used as a benchmark. In a nutshell, if it cannot be compiled, it will never fly. So I would ask you guys to be considerate of this point.</div><div><br></div><div>My concerns might not even be valid, and I do apologize if that is the case. I just must admit that, as an amateur software developer, I miss some of the jargon used here when talking about more technical issues on software development.</div><div><br></div><div>Cheers,</div><div>Pedro</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 19, 2016 at 7:18 AM, Luigi Pirelli <span dir="ltr"><<a href="mailto:luipir@gmail.com" target="_blank">luipir@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi List<br>
<br>
The Binary problem (?):<br>
In this recently added plugin I can find cython modules precompiled in<br>
forms odf pyd, or so. (and relative cython code)<br>
Following the presentation in: <a href="https://www.youtube.com/watch?v=zz3jbM_JBTo" rel="noreferrer" target="_blank">https://www.youtube.com/watch?<wbr>v=zz3jbM_JBTo</a><br>
I understand that the reason is performance, but how to prevent<br>
loading malicious shared objects?<br>
<br>
* probably we should start to plan a safe infrastructure to allow<br>
uploading plugin with compiled modules... any idea other than a simple<br>
checksum?<br>
<br>
The license problem (?):<br>
other question is regarding the cython algorithm. I can read in<br>
<a href="https://github.com/AequilibraE/AequilibraE/blob/master/aequilibrae/paths/AoN.pyx#L23" rel="noreferrer" target="_blank">https://github.com/<wbr>AequilibraE/AequilibraE/blob/<wbr>master/aequilibrae/paths/AoN.<wbr>pyx#L23</a><br>
"Codes for route ennumeration, DAG construction and Link nesting were<br>
written by Pedro Camargo (2013) and have all their rights reserved to<br>
the author"<br>
<br>
Obviously the author has right reserved, an in the same code the<br>
author refer to the LICENSE.txt that is a standard GPL license:<br>
here: <a href="https://github.com/AequilibraE/AequilibraE/blob/master/aequilibrae/paths/AoN.pyx#L18" rel="noreferrer" target="_blank">https://github.com/<wbr>AequilibraE/AequilibraE/blob/<wbr>master/aequilibrae/paths/AoN.<wbr>pyx#L18</a><br>
and here: <a href="https://github.com/AequilibraE/AequilibraE/blob/master/LICENSE.TXT" rel="noreferrer" target="_blank">https://github.com/<wbr>AequilibraE/AequilibraE/blob/<wbr>master/LICENSE.TXT</a><br>
<br>
how should we have to read the "right reserved" sencence by the author?<br>
<br>
regards<br>
Luigi Pirelli<br>
<br>
******************************<wbr>******************************<wbr>******************************<wbr>********<br>
* Boundless QGIS Support/Development: lpirelli AT boundlessgeo DOT com<br>
* LinkedIn: <a href="https://www.linkedin.com/in/luigipirelli" rel="noreferrer" target="_blank">https://www.linkedin.com/in/<wbr>luigipirelli</a><br>
* Stackexchange: <a href="http://gis.stackexchange.com/users/19667/luigi-pirelli" rel="noreferrer" target="_blank">http://gis.stackexchange.com/<wbr>users/19667/luigi-pirelli</a><br>
* GitHub: <a href="https://github.com/luipir" rel="noreferrer" target="_blank">https://github.com/luipir</a><br>
* Mastering QGIS 2nd Edition:<br>
* <a href="https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition" rel="noreferrer" target="_blank">https://www.packtpub.com/big-<wbr>data-and-business-<wbr>intelligence/mastering-qgis-<wbr>second-edition</a><br>
******************************<wbr>******************************<wbr>******************************<wbr>********<br>
<div><div class="h5"><br>
<br>
On 18 December 2016 at 14:28,  <<a href="mailto:noreply@qgis.org">noreply@qgis.org</a>> wrote:<br>
><br>
> Plugin AequilibraE approval by pcav.<br>
> The plugin version "[1102] AequilibraE 0.3.3" is now approved<br>
> Link: <a href="http://plugins.qgis.org/plugins/AequilibraE/" rel="noreferrer" target="_blank">http://plugins.qgis.org/<wbr>plugins/AequilibraE/</a><br>
</div></div>> ______________________________<wbr>_________________<br>
> Qgis-developer mailing list<br>
> <a href="mailto:Qgis-developer@lists.osgeo.org">Qgis-developer@lists.osgeo.org</a><br>
> List info: <a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">http://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a><br>
> Unsubscribe: <a href="http://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">http://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a><br>
</blockquote></div><br></div>