<div dir="ltr"><div class="gmail_extra">On Tue, Mar 7, 2017 at 9:12 AM, Paul Blottiere <span dir="ltr"><<a href="mailto:paul.blottiere@oslandia.com" target="_blank">paul.blottiere@oslandia.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000"><span class="">
    <p><br>
      > It sounds strange to me that it was never observed in
      production, but I did not search the hub for an existing ticket,
      it might have been reported.</p>
    <p><br>
    </p>
    </span><p>The test seems to fail in very specific conditions (that I have
      not yet found). As Mathias suggested, I made a loop on the test.
      And even with 1000 iterations, it's still not failing whatever the
      branch (master or 2.14)... Maybe it has never been observed.</p><span class="HOEnZb"><font color="#888888">
    <p><br>
    </p>
    <p>Paul<br>
    </p></font></span><div><div class="h5">
    <p><br></p></div></div></div></blockquote><div><br></div><div>I tried to reproduce the issue locally without success. <br><br></div><div>I suggest for now to either split the printing tests into a separate file or better (if there is single test failing) just decorate the test as allowed to fail so that the whole suite does not fail.<br><br></div><div>When done, we can re-enable the server test in travis.<br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div><div class="h5"><p>
    </p>
    <div class="m_-1860528929036589083moz-cite-prefix">On 03/07/2017 08:53 AM, Alessandro
      Pasotti wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">On Tue, Mar 7, 2017 at 8:48 AM, Paul
            Blottiere <span dir="ltr"><<a href="mailto:paul.blottiere@oslandia.com" target="_blank">paul.blottiere@oslandia.com</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote">
              <div>
                <p>Alessandro,<br>
                </p>
                <span>
                  <p><br>
                  </p>
                  <p>> do you have clue if the multi-threading
                    rendering could be the root cause of this issue?</p>
                </span>
                <p>The test is failing on travis for 2.14 too. However,
                  PR about the replacement of the QgsMapRenderer and the
                  parallel rendering activation are not backported in
                  2.14. So, as it happens both on master and 2.14, it
                  seems to be independent from the rendering step.<br>
                </p>
                <p><br>
                </p>
                <p>Only unit tests on the getprint service has been
                  backported and before that, there was none. So I think
                  that the failing test is just underlying an old issue
                  which was there even before we started to refactor the
                  server.</p>
                <p><br>
                </p>
                <p>What do you think?<span class="m_-1860528929036589083HOEnZb"><br>
                  </span></p>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>I'm afraid you are right ...<br>
              <br>
            </div>
            <div>It will be difficult to spot it out, by the way I think
              that the test did a good work to discover this issue.<br>
              <br>
            </div>
            <div>It sounds strange to me that it was never observed in
              production, but I did not search the hub for an existing
              ticket, it might have been reported.<br>
            </div>
            <div><br>
              <br>
            </div>
            <blockquote class="gmail_quote">
              <div>
                <p><span class="m_-1860528929036589083HOEnZb"> </span></p>
                <span class="m_-1860528929036589083HOEnZb">
                  <p><br>
                  </p>
                  <p>Paul<br>
                  </p>
                </span>
                <div>
                  <div class="m_-1860528929036589083h5">
                    <p><br>
                    </p>
                    <br>
                    <div class="m_-1860528929036589083m_-3486877170006258993moz-cite-prefix">On
                      03/07/2017 08:16 AM, Alessandro Pasotti wrote:<br>
                    </div>
                  </div>
                </div>
                <blockquote type="cite">
                  <div>
                    <div class="m_-1860528929036589083h5">
                      <div dir="ltr">
                        <div class="gmail_extra">
                          <div class="gmail_quote">On Mon, Mar 6, 2017
                            at 5:30 PM, Paul Blottiere <span dir="ltr"><<a href="mailto:blottiere.paul@gmail.com" target="_blank">blottiere.paul@gmail.com</a>></span>
                            wrote:<br>
                            <blockquote class="gmail_quote">
                              <div>
                                <p>Hi Alessandro,</p>
                                <span>
                                  <p><br>
                                  </p>
                                  <blockquote type="cite">
                                    <blockquote type="cite">
                                      <div dir="ltr">
                                        <div class="gmail_extra">can you
                                          please have a look?<br>
                                          <br>
                                        </div>
                                        <div class="gmail_extra">I'm
                                          afraid this failure is not a
                                          problem in the test itself but
                                          a symptom of more serious
                                          issue: the map is completely
                                          missing from the generated
                                          print.<br>
                                        </div>
                                      </div>
                                    </blockquote>
                                  </blockquote>
                                  <blockquote type="cite">
                                    <blockquote type="cite">
                                      <div dir="ltr">
                                        <div class="gmail_extra"> </div>
                                      </div>
                                    </blockquote>
                                    FYI, the same test also fails on
                                    2.14 as discussed on the following
                                    commit:<br>
                                  </blockquote>
                                  <br>
                                </span> I took a look but I cannot
                                reproduce the failing test
                                test_wms_getprint_srs. <br>
                                <br>
                                Actually, I have tested it within the
                                next environment without issues:<br>
                                - master on Debian<br>
                                - release-2_14 on Ubuntu.<br>
                                <br>
                                Can anyone confirm?<span class="m_-1860528929036589083m_-3486877170006258993HOEnZb"><br>
                                  <br>
                                  Paul<br>
                                </span></div>
                            </blockquote>
                          </div>
                          <br>
                          <br>
                        </div>
                        <div class="gmail_extra">Paul, <br>
                          <br>
                        </div>
                        <div class="gmail_extra">Thanks for looking into
                          this, I'll do some local testing shortly, do
                          you have clue if the multi-threading rendering
                          could be the root cause of this issue?<br>
                          <br>
                        </div>
                        <div class="gmail_extra">A s a side note, I
                          would recommend to refactor the server test
                          and split it in smaller dedicated tests for
                          the different services.<br>
                          <br>
                          <br>
                        </div>
                        <div class="gmail_extra"><br>
                          -- <br>
                          <div class="m_-1860528929036589083m_-3486877170006258993gmail_signature" data-smartmail="gmail_signature">Alessandro
                            Pasotti<br>
                            w3:   <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
                        </div>
                      </div>
                      <br>
                      <fieldset class="m_-1860528929036589083m_-3486877170006258993mimeAttachmentHeader"></fieldset>
                      <br>
                    </div>
                  </div>
                  <span>
                    <pre>______________________________<wbr>_________________
Qgis-developer mailing list
<a class="m_-1860528929036589083m_-3486877170006258993moz-txt-link-abbreviated" href="mailto:Qgis-developer@lists.osgeo.org" target="_blank">Qgis-developer@lists.osgeo.org</a>
List info: <a class="m_-1860528929036589083m_-3486877170006258993moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/qgis-developer</a>
Unsubscribe: <a class="m_-1860528929036589083m_-3486877170006258993moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/qgis-developer</a></pre>
    </span></blockquote>
    

  </div>

</blockquote></div>


-- 
<div class="m_-1860528929036589083gmail_signature" data-smartmail="gmail_signature">Alessandro Pasotti
w3:   <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div></div>



</blockquote>
</div></div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Alessandro Pasotti<br>w3:   <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div></div>