<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ok - I find this thread very confusing. Does this acknowledgement mean</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">that you WILL remove these ifdefs from the PR?</blockquote></blockquote><div>Yes, indeed. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Here's the thing: I *want* your work to land in QGIS. It's important</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">stuff, and needs to be addressed. But in its current form it won't be</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">merged - it's been independently reviewed by two core developers who</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">have both requested changes. I hate to see all this effort you've put</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">in wasted, but you need to rework your approach before this can be</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">merged.</blockquote></blockquote><div><br></div><div>Yesterday I got QGIS 3 working on my machine.</div><div>So now I can work on this version. </div><div><br></div><div>In the last 3 months on a new version of the Georefencer:</div><div><br></div><div><a href="https://github.com/mj10777/QGIS/wiki/QGIS-Enhancement:-Georeferencer">https://github.com/mj10777/QGIS/wiki/QGIS-Enhancement:-Georeferencer</a><br></div><div><br></div><div>for which I have applied a grant for.</div><div><br></div><div>This needs a working gdal 2, so before I can start the port of the Georeferencer to QGIS 3 (where I assume that there will be API changes to deal with), this matter needs to be resolve - so I will attempt to merge the 2.</div><div><br></div><div>Any idea of any api changes in QgsOgrProvider?</div><div><br></div><div>A pity that the needed changes were not done in 2015 when first reported, during the gdal 2 beta phase.</div><div><br></div><div>Mark</div></div>