Hi Alessandro<div><br></div><div>replies <font color="#ff0000">inline</font><br><br>Le lundi 5 juin 2017, Alessandro Pasotti <<a href="mailto:apasotti@gmail.com">apasotti@gmail.com</a>> a écrit :<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 5, 2017 at 1:54 PM, Stéphane Henriod <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','stephanebek@gmail.com');" target="_blank">stephanebek@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Alessandro<div><br></div><div><div>First of all, thank you so much for this work, it looks really great already!</div><div><br></div><div>Here a few comments / ideas after a few quick tests, I let you filter which ones could actually be part of this phase and which ones should be left out for a future phase 2</div></div></blockquote><div><br><div>Hi, <br><br></div>thanks for testing!<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">That's the least I can do when someone has already done the hard part, i.e. developing :-)</font></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>- "Raster" is not consistent: it is confusing that the file selector opens directly. The behavior should mimick the "vector" (open the file selector only when the user clicks on "browse")</div></div></blockquote><div><br></div><div>yeah, I know, this has been already discussed in the PR comments, please have a look.<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">Yes, I've seen that. But I was not sure if a consensus has been reached. Will it stay like this for now or is it still open for discussion? I would favor the "extra-click" that would make it more consistent with the other providers</font></div><div><font color="#ff0000"><br></font></div><div><font color="#ff0000"><br></font></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>- The "DB2" logo should be cleaned (at least add transparency)</div></div></blockquote><div><br></div><div><br>Sorry, I've no graphics design skills, and this task is really something that a not-programmer can contribute to. Changing the icons was not in scope btw.<br></div></div></div></div></div></div></blockquote><div><br></div><div><br></div><div><font color="#ff0000">I don't have such skills either but I'd be happy to try and at least make the background transparent. I however don't know where to find the original icon and how to push it back, once I have (maybe) successfully improved it. (This had also been raised by Nyall)</font></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>- When I click on "Browse", the file selector window opens behind the Data Source Manager</div></div></blockquote><div><br></div><div>Not sure I understand what you mean here, probably need more details, and it seems like a bug.<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">Here what I mean: <a href="https://vimeo.com/220330186">https://vimeo.com/220330186</a> </font></div><div><font color="#ff0000"><br></font></div><div><font color="#ff0000">But it is not super consistent and doesn't necessarily happen everytime</font></div><div><font color="#ff0000"><br></font></div><div><font color="#ff0000">I opened an issue here: <a href="https://issues.qgis.org/issues/16666">https://issues.qgis.org/issues/16666</a></font></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>- I would change the order of the providers: move the "Delimited text" just below raster (so that we have all file-based providers together). And maybe separate (visually) the providers in sections: "Files", "Databases", "Web services", "Virtual" (or something like this). Also,"ArcGIS Feature Server" should probably be just after "ArcGIS Map Server"</div></div></blockquote><div><br></div><div><br>If I'm not mistaken, the order is the same order we had before for the menu items and the icons, I did not alter the order (at least that was not my intention).<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">I indeed think that you kept the original order. But would it be out of the scope of this first phase to clean up and make this order more intuitive? It seems to me like a good opportunity but maybe I am underestimating the associated workload?</font></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>- It would be super useful to be able to display a basemap (OSM, Google, etc) directly from the Data Source Manager, without having to configure "XYZ Tiles" in the browser.Would it be possible in this phase to add 1 entry in the Data source manager "Webmaps" where the user could simply pick in a drop-down one of the most common webmaps (and could add additional XYZ tiles)? This would be a golden feature for non-power users. </div></div></blockquote><div><br></div><div><br>This is totally unrelated, but AFAIK there are plans to add some default xyz maps to the mix for 3.0.<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">Ok, thanks for the info!</font></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div><br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>Thanks again, I will try to test it a bit deeper in the coming days</div><div><br></div><div>Cheers</div><span><font color="#888888"><div>Stéphane</div></font></span><div><div><div><br></div></div></div></div></blockquote><div><br></div><div>Thanks again for the feed-back!<br><br></div><div>Cheers.<br></div></div></div></div></div></div></blockquote><div><br></div><div><font color="#ff0000">You're very welcome!</font></div><div><font color="#ff0000">Cheers</font></div><div><font color="#ff0000"><br></font></div><div><font color="#ff0000">Stéphane</font></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div><div></div><br>Le lundi 5 juin 2017, Alessandro Pasotti <<a href="javascript:_e(%7B%7D,'cvml','apasotti@gmail.com');" target="_blank">apasotti@gmail.com</a>> a écrit :<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi Stéphane,<br><br></div>Thanks for testing the new dialog!<br><br>I think that if you find a bug (a crash or something that doesn't work as expected) you should open an issue on the hub and assign it to me.<br><br></div>For general feed-back or change proposal for the UI/UX you can either use this thread or make a PR with the proposed changes and discuss them in the the PR.<br><br></div>Cheers<br><div><div><div><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jun 4, 2017 at 8:14 PM, Stéphane Henriod <span dir="ltr"><<a>stephanebek@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Alessandro<div><br></div><div>I just downloaded the latest nightly build and will make some tests in the coming days. What would be the most efficient / useful way to give you feedback and comments? On this thread?</div><div><br></div><div>Thanks and cheers</div><span><font color="#888888"><div><br></div></font></span><div><span><font color="#888888">Stéphane</font></span><div><div><br><br>Le jeudi 1 juin 2017, Alessandro Pasotti <<a>apasotti@gmail.com</a>> a écrit :<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">On Thu, Jun 1, 2017 at 11:22 AM, Stéphane Henriod <span dir="ltr"><<a>stephanebek@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I really look forward to testing it :-) Thanks a lot for our involvement here!<div><div><div><br></div></div></div></blockquote><div><br><br></div><div>Thanks to Boundless for funding the development and thanks to all of you who participated with design, mockups, ideas, comments and reviews!<br><br></div><div>This was a nice and effective cooperation.<br><br><br></div><div>BTW, if you can't wait, a Docker with a nigthly build of the PR branch is available as "boundlessgeo/qgis-testing-env<wbr>ironment:unified-button"<br><br></div><div>Cheers<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div><br>Le mercredi 31 mai 2017, Alessandro Pasotti <<a>apasotti@gmail.com</a>> a écrit :<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div>Hi,<br><br></div>final update: the development of what was in phase 1 is done. <br></div><br>Actually, a bit more than phase 1 considering that we've redesigned the delimited text dialog GUI and I've done quite a bit of small refactorings of the providers selection dialogs interfaces.<br><br></div>There has been a lot of feed-back, thank you all!<br> <br>As expected, there is no complete agreement over the final GUI bits for the menus and toolbars, and we still miss an icon (the green plus that I've used was only meant as a placeholder). I tried to keep the old toolbar available (disabled by default) mainly
because it can spare a click and power users might want it back. Also,
the new icon is the most prominent in the left bar and it's the first
menu item in the layers menu.<br><br></div>I have not a strong opinion about those toolbars and menus but I think I should wait no more and merge it as it is, then give the people some time to test the actual implementation and decide how to improve it.<br></div><div><br>I kept the controversial part in a single commit so that it will be very easy to revert and propose a different placement for menus, icons and toolbars.<br></div><br><br></div>Any objections if I proceed?<br><div><div><div><div><br><div><div><br></div></div></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 24, 2017 at 2:29 PM, Alessandro Pasotti <span dir="ltr"><<a>apasotti@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>Hi,<br><br>a quick update:<br></div><br>I've prepared a PR with a working prototype in <a href="https://github.com/qgis/QGIS/pull/4629" target="_blank">https://github.com/qgis/QGIS/p<wbr>ull/4629</a>, I need some feed-back and some help, expecially UX/UI about if we want it as a dockable dialog too (and how to make it user-configurable).<br><br></div>Feed-back welcome (but please keep it limited in scope to phase 1).<br><br><div>Cheers<br><br></div><div> <br></div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Fri, May 19, 2017 at 9:45 AM, Richard Duivenvoorde <span dir="ltr"><<a>rdmailings@duif.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On 19-05-17 01:23, Nyall Dawson wrote:<br>
<br>
> On this note - I've recently discovered the need for some type of<br>
> reusable layer selection widget which allows choice of existing<br>
> layers/loading new layers from the file system/loading new layers from<br>
> available db/online connections. This would be extremely valuable for<br>
> processing too!<br>
><br>
> So I'm really glad to hear that you'll be pushing ahead with this work<br>
> - thanks Boundless!<br>
<br>
</span>Yep, and thanks Alessandro for the screenie. Makes me want more!<br>
<br>
@Nyall in Essen the talk was to start with what Alessandro wrote in his<br>
email, so 1 dialog 'merging' all buttons/widgets/dialogs into one, reuse<br>
as much as possible. So it was possible to get it into 3.0<br>
<br>
Off course people (.../me) started brainstorming about features which<br>
w/could be added too :-)<br>
<br>
Your idea adds (I think) to the idea to make some kind of<br>
'datamanagement-console' in near future, where you can create/copy<br>
data(!), move data around (browser part) or delete it.<br>
Your note fits in this isn't it?<br>
<br>
Regards,<br>
<br>
Richard<br>
<div><div><br>
<br>
______________________________<wbr>_________________<br>
QGIS-Developer mailing list<br>
<a>QGIS-Developer@lists.osgeo.org</a><br>
List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/qgis-developer</a><br>
Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailma<wbr>n/listinfo/qgis-developer</a></div></div></blockquote></div><br><br clear="all"><br></div></div><span>-- <br><div>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div>
</blockquote></div><br><br></div></div><div><div>-- <br><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span><div><div dir="ltr"><div><div dir="ltr"><br></div><div dir="ltr">“When you travel, remember that a foreign country is not designed to
make you comfortable. It is designed to make its own people
comfortable." -- Clifton Fadiman<span dir="ltr"><br></span></div></div></div></div></span></div></div></div></div></div></div></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div></div>
</blockquote></div></div></div><div><div><br><br>-- <br><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span><div><div dir="ltr"><div><div dir="ltr"><br></div><div dir="ltr">“When you travel, remember that a foreign country is not designed to
make you comfortable. It is designed to make its own people
comfortable." -- Clifton Fadiman<span dir="ltr"><br></span></div></div></div></div></span></div></div></div></div></div></div></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div>
</blockquote></div></div></div><div><div><br><br>-- <br><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span><div><div dir="ltr"><div><div dir="ltr"><br></div><div dir="ltr">“When you travel, remember that a foreign country is not designed to
make you comfortable. It is designed to make its own people
comfortable." -- Clifton Fadiman<span dir="ltr"><br></span></div></div></div></div></span></div></div></div></div></div></div></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div>Alessandro Pasotti<br>w3: <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div></div></div></div>
</blockquote></div><br><br>-- <br><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span><div><div dir="ltr"><div><div dir="ltr"><br></div><div dir="ltr">“When you travel, remember that a foreign country is not designed to
make you comfortable. It is designed to make its own people
comfortable." -- Clifton Fadiman<span dir="ltr"><br></span></div></div></div></div></span></div></div></div></div></div></div></div><br>