<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Dave, hi Nyall,</p>
<p>Thanks for all your thoughts and work on this. The approach that
is currently being developed sounds like a very reasonable one
given the remaining time for 3.0.</p>
<p><br>
</p>
<p>Another idea I had to handle things like this was an "activate
condition" for actions. The activate condition for the duplicate
feature action could be a simple `@layer_editable`.</p>
<p>The tricky thing is, that variables (or even expression
functions) used within such a construct will need to be notifiable
(e.g. here upon layer edit state change, but in theory it could
depend on other things like `selected_feature_count(@layer) >
2`), so the expression engine knows when an expression needs to be
re-evaluated.<br>
</p>
<p>It will be a non-trivial thing to do and I'm not yet convinced
it's worth it, but I could imagine that we find other areas in
QGIS where such an interactive machinery to enable button states
or change labels interactively based on expressions can come in
handy.</p>
<p>Enjoy Madeira, I miss you all !!</p>
<p>Matthias<br>
</p>
<br>
<div class="moz-cite-prefix">On 02/21/2018 03:55 PM, David Signer
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1519224931-e87b25e221e03f8497e74dd0e2b1e8a2@opengis.ch">
<div>Hi Nyall<br>
</div>
<div><br>
</div>
<div>I'll start with it today. So possibly it's done before the
23th.<br>
</div>
<div><br>
</div>
<div>We could keep it as an Action, only enabled when the layer is
editable.<br>
</div>
<div>This would include an attribute of MapLayerAction, if it
should be enabled only in editable mode or always (first case
for the duplication-action). The user actions would need such a
attribute as well. <br>
</div>
<div>Probably we could integrate this attribute as another
scope-value, and use the scopes as well for the MapLayerActions.<br>
</div>
<div>Then we need to decide on what scopes it should be displayed:<br>
</div>
<div>- Canvas (in the main toolbar)<br>
</div>
<div>- Layer (in the toolbar of attribute list)<br>
</div>
<div>- Feature (in the actions of attribute form, right click on a
feature in the form view, right click on the feature on canvas)<br>
</div>
<div>- Field (right click on a field in row of attribute table,
right click on field at identify result panel)<br>
</div>
<div><br>
</div>
<div>What do you think?<br>
</div>
<div><br>
</div>
<div>Thanks for the ini-configuration anyway. Probably we will
need it as well. <br>
</div>
<div><br>
</div>
<div>Regards<br>
</div>
<div>David</div>
<div><br>
</div>
<div><i>21 February 2018 05:27 Nyall Dawson
<a class="moz-txt-link-rfc2396E" href="mailto:nyall.dawson@gmail.com"><nyall.dawson@gmail.com></a> wrote:</i><br>
</div>
<blockquote class="infmailquote">
<div>On 19 February 2018 at 16:24, Nyall Dawson wrote: <br>
</div>
<div>> On 15 February 2018 at 03:16, David Signer wrote: <br>
</div>
<div>>> Dear all <br>
</div>
<div>>> <br>
</div>
<div>>> I agree (and I guess everyone else does), that
it's not okay that this <br>
</div>
<div>>> feature is enabled when the layers are not in
editable mode. I already <br>
</div>
<div>>> started to fix that, but because of time I had to
decide to finish it next <br>
</div>
<div>>> week. <br>
</div>
<div>>> <br>
</div>
<div>>> Anyway, there is still the question, where it
should appear. IMHO it should <br>
</div>
<div>>> be everywhere, where you can add and delete
features. If it's a MapTool it <br>
</div>
<div>>> could be there as well, I think. I'll have to
think about that. <br>
</div>
<div>> <br>
</div>
<div>> Thanks for your flexibility here! <br>
</div>
<div>> <br>
</div>
<div>> What's the chance of getting this resolved before 3.0
final? If we <br>
</div>
<div>> can't, can we please ifdef this out for 3.0 release
and defer to 3.2? <br>
</div>
<div>> <br>
</div>
<div><br>
</div>
<div>In <a class="moz-txt-link-freetext" href="https://github.com/qgis/QGIS/pull/6399">https://github.com/qgis/QGIS/pull/6399</a> I implement a
advanced <br>
</div>
<div>settings option, "tools\showDuplicateFeatureActions" to
control <br>
</div>
<div>whether these actions are shown. By default it's off, but
interested <br>
</div>
<div>organisations can set the flag in their
qgis_global_settings.ini to <br>
</div>
<div>show these actions. <br>
</div>
<div><br>
</div>
<div>I think that's a fair approach - it means that
users/organisations <br>
</div>
<div>which require this feature can still use it in 3.0, whilst
at the same <br>
</div>
<div>time avoiding exposing the functionality to users by
default until it <br>
</div>
<div>is refined. <br>
</div>
<div><br>
</div>
<div>Nyall <br>
</div>
</blockquote>
<div><br>
</div>
<div><br>
</div>
<div id="editorUserSignature">
<p><span class="font" style="font-family:monospace">---------------------</span><br>
</p>
<p><span class="font" style="font-family:monospace">David Signer</span><br>
</p>
<p><span class="font" style="font-family:monospace">Programmer
OPENGIS.CH</span><br>
</p>
<p><span class="font" style="font-family:monospace">Wülflingerstrasse
213</span><br>
</p>
<p><span class="font" style="font-family:monospace">CH - 8408
Winterthur</span><br>
</p>
<p><span class="font" style="font-family:monospace">+ 41 (0) 78
766 13 03</span><br>
</p>
<p><span class="font" style="font-family:monospace">---------------------</span><br>
</p>
</div>
<div><br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
QGIS-Developer mailing list
<a class="moz-txt-link-abbreviated" href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a>
List info: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
Unsubscribe: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a></pre>
</blockquote>
<br>
</body>
</html>