<div dir="ltr"><div>common-qgis-python like that we created in Boundless when we where there [1] had this intention:<br></div><div>1) create a set of common snippets</div><div>2) centralize maintenance</div><div>3) avoid re implement common problems (rised during dev for that specific company)</div><div><br></div><div>the main problems I see are:</div><div>1) I would feel confortable if repo [1] would be out of control of a private company.</div><div><br></div><div>My option would be:</div><div>1) move to QGIS repo</div><div>2) manage any new snippet or module using an Enhancement Proposal (QEP)</div><div><br></div><div>Not clear to me the advantages of using a separate repo added via submodule.</div><div><br></div><div class="gmail_extra"><div><div class="gmail_signature" data-smartmail="gmail_signature">Luigi Pirelli</div><div class="gmail_signature" data-smartmail="gmail_signature"><br></div><div class="gmail_signature" data-smartmail="gmail_signature"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">[1] <a href="https://github.com/boundlessgeo/lib-qgis-commons">https://github.com/boundlessgeo/lib-qgis-commons</a></span><br><br>**************************************************************************************************<br>* LinkedIn: <a href="https://www.linkedin.com/in/luigipirelli" target="_blank">https://www.linkedin.com/in/luigipirelli</a><br>* Stackexchange: <a href="http://gis.stackexchange.com/users/19667/luigi-pirelli" target="_blank">http://gis.stackexchange.com/users/19667/luigi-pirelli</a><br>* GitHub: <a href="https://github.com/luipir" target="_blank">https://github.com/luipir</a><br>* Mastering QGIS 2nd Edition:<br>* <a href="https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition" target="_blank">https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition</a><br>* Hire me: <a href="http://goo.gl/BYRQKg" target="_blank">http://goo.gl/BYRQKg</a><br>**************************************************************************************************</div></div>
<br><div class="gmail_quote">On 4 April 2018 at 21:59, Tim Sutton <span dir="ltr"><<a href="mailto:tim@kartoza.com" target="_blank">tim@kartoza.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hi<div><br></div><div>Thats really cool Richard. What about tweaking the plugin builder plugin to provide a new template for a locator plugin. That way the locator basic framework could be provided but we could keep the plugins discrete?</div><div><br></div><div>Regards</div><div><br></div><div>Tim<div><div class="h5"><br><div><br><blockquote type="cite"><div>On 04 Apr 2018, at 21:06, Richard Duivenvoorde <<a href="mailto:rdmailings@duif.net" target="_blank">rdmailings@duif.net</a>> wrote:</div><br class="m_7685689457390471649Apple-interchange-newline"><div><div>Devs & Python devs,<br><br>I've written one plugin, which when installed adds 3 QLocator filters to<br>your little search-bar in the lower left corner of QGIS3:<br>- a Nominatim geocoder/filter<br>- a Google geocoder/filter<br>- a PDOK (dutch) geocoder/filter<br><br>The use of these geocoders/locators in QGIS is REALLY usefull, just<br>search for 'eiffel', and google will let you zoom to the eiffeltower<br>(even being written in dutch, french or german....)<br><br>The nominatim geocoder is also great, and the dutch geocoder can fly<br>over NL with just a zip+housenumber.<br><br>Code is here:<br><a href="https://github.com/rduivenvoorde/qgislocator" target="_blank">https://github.com/<wbr>rduivenvoorde/qgislocator</a><br>Plugin zip to install is here:<br><a href="https://github.com/rduivenvoorde/qgislocator/raw/master/qgislocator_0.1.1.zip" target="_blank">https://github.com/<wbr>rduivenvoorde/qgislocator/raw/<wbr>master/qgislocator_0.1.1.zip</a><br><br>Now my main point: I discussed this with Nyall, if we should create a<br>mega-locator-plugin or keep the locator filter/plugins small.<br>Adding a geocoder to the current form is easy: just reimplement a filter<br>(see locatorfilters) for your national geocoder service, and you are done.<br><br>The advantage of having ONE mega-plugin:<br>- it is easy to have some 'basefilter' in which to have some common coce<br>- having one plugin, forces devs to use QgsNetworkRequest (here via<br>Alessandro's QgsNetworkAccessManager. So no more use of httplib2,<br>Requests etc which fail on proxied environments if not fully implemented).<br><br>BUT, it is probably better if we split up all the possible<br>locatorfilters (not everybody on the world is interested in dutch<br>addresses :-) ...<br><br>So my main point:<br>- how to give everybody the possibilty to implement a locator class, BUT<br>also share a common base class or use the same QgsNetworkAccessManager<br>moduel?<br><br>Some options:<br>- we create a separate repo for 'common' python classes, and via git<br>submodules everybody pulls in it's own copy of those classes<br>- we create a common-qgis-python module which would ship with QGIS (with<br>filterbaseclass, QgsNetworkAccessManager, and other ideas from the<br>Boundless commons lib).<br><br>Let me know any opinions/ideas.<br><br>Regards,<br><br>Richard Duivenvoorde<br><br>PS, wannatry? Download<br><a href="https://github.com/rduivenvoorde/qgislocator/raw/master/qgislocator_0.1.1.zip" target="_blank">https://github.com/<wbr>rduivenvoorde/qgislocator/raw/<wbr>master/qgislocator_0.1.1.zip</a><br>and use Install from ZIP in the plugin manager. Use '2022zj' to search<br>PDOK, or 'eiffel' to search Google. Note that you may need a google key<br>to use their geocoder.<br><br><br>______________________________<wbr>_________________<br>QGIS-Developer mailing list<br><a href="mailto:QGIS-Developer@lists.osgeo.org" target="_blank">QGIS-Developer@lists.osgeo.org</a><br>List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a><br>Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a></div></div></blockquote></div><br></div></div><div>
<div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;line-height:normal;text-align:center"><span>—</span></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;letter-spacing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;line-height:normal;text-align:center"><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><br class="m_7685689457390471649Apple-interchange-newline" style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span><span><span><span><span><span><span><span><span><img id="m_76856894573904716492D66D5E0-D6C7-44BE-BCB8-BBC4F8890C9E" src="cid:1A5DF6DE-E302-4C28-BFBD-29663CBF1351"></span><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br class="m_7685689457390471649Apple-interchange-newline"><br class="m_7685689457390471649Apple-interchange-newline"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal"><b>Tim Sutton</b></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal"><b>Co-founder:</b><span class="m_7685689457390471649Apple-converted-space"> </span>Kartoza</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal"><b>Project chair:</b><span style="font-weight:normal"><span class="m_7685689457390471649Apple-converted-space"> </span><a href="http://QGIS.org" target="_blank">QGIS.org</a></span></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal">Visit <a href="http://kartoza.com/" target="_blank"><span>http://kartoza.com</span></a> to find out about open source:</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal">Desktop GIS programming services</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal">Geospatial web development</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal">GIS Training</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal">Consulting Services</div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal;min-height:14px"><br></div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal"><b>Skype</b>: timlinux </div><div style="color:rgb(0,0,0);font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:center;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;margin:0px;line-height:normal"><b>IRC:</b><span class="m_7685689457390471649Apple-converted-space"> </span>timlinux on #qgis at <a href="http://freenode.net" target="_blank">freenode.net</a></div>
</span></span></span></span></span></span></span></span></span></div>
</div><br></div></div><br>______________________________<wbr>_________________<br>
QGIS-Developer mailing list<br>
<a href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a><br>
List info: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a><br>
Unsubscribe: <a href="https://lists.osgeo.org/mailman/listinfo/qgis-developer" rel="noreferrer" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/qgis-<wbr>developer</a><br></blockquote></div><br></div></div>