<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 10, 2018 at 2:21 PM, andreaerdna <span dir="ltr"><<a href="mailto:andreaerdna@libero.it" target="_blank">andreaerdna@libero.it</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Dear developers,<br>
about two months ago I reported a longstanding bug in QGIS 2.18<br>
(<a href="https://issues.qgis.org/issues/18132" rel="noreferrer" target="_blank">https://issues.qgis.org/<wbr>issues/18132</a>) about a wrong dpi resolution in<br>
images exported from composer.<br>
<br>
Two weeks later I sent a pull request<br>
(<a href="https://github.com/qgis/QGIS/pull/6524" rel="noreferrer" target="_blank">https://github.com/qgis/QGIS/<wbr>pull/6524</a>) with a little commit that would fix<br>
the bug, and about a month ago Nyall Dawson (thanks you!) slightly revised<br>
and tweaked the commit (<a href="https://github.com/qgis/QGIS/pull/6620" rel="noreferrer" target="_blank">https://github.com/qgis/QGIS/<wbr>pull/6620</a>).<br>
<br>
Since then, the pull request was not yet merged.<br>
<br>
I don't know well the procedures, so I'd like to know if there is anything I<br>
have to do to get the pull request merged in time for the next 2.18 point<br>
release.<br>
<br>
Thank you in advance.<br>
<br>
Andrea Giudiceandrea<br>
<br></blockquote></div><br><br></div><div class="gmail_extra">Hi Andrea, <br><br></div><div class="gmail_extra">I'm sorry for the delay, looks like there is at least one failing test: <a href="https://travis-ci.org/qgis/QGIS/jobs/354180088#L1367">https://travis-ci.org/qgis/QGIS/jobs/354180088#L1367</a><br><br></div><div class="gmail_extra">this must be fixed before anybody could possibly merge.<br><br></div><div class="gmail_extra">If the failure is a false negative, you should just create a new reference image for the the test (and possibly a mask image).<br><br></div><div class="gmail_extra">Unfortunately this is not trivial if you've not done it before, and requires some time even if you've done it before.<br><br></div><div class="gmail_extra">See: <a href="https://docs.qgis.org/testing/en/docs/developers_guide/unittesting.html#comparing-images-for-rendering-tests">https://docs.qgis.org/testing/en/docs/developers_guide/unittesting.html#comparing-images-for-rendering-tests</a><br><br></div><div class="gmail_extra">See also: <a href="https://dash.orfeo-toolbox.org/testDetails.php?test=68355414&build=312657">https://dash.orfeo-toolbox.org/testDetails.php?test=68355414&build=312657</a> (look at the very end of the page)<br><br></div><div class="gmail_extra">Hope this helps.<br clear="all"></div><div class="gmail_extra"><br>-- <br><div class="gmail_signature">Alessandro Pasotti<br>w3:   <a href="http://www.itopen.it" target="_blank">www.itopen.it</a></div>
</div></div>