<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, May 23, 2018 at 4:28 PM, Jürgen E. Fischer <span dir="ltr"><<a href="mailto:jef@norbit.de" target="_blank">jef@norbit.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Vittorio,<br>
<span class="m_8130274359849966436m_-2251676561364842940gmail-"><br>
On Wed, 23. May 2018 at 15:31:44 +0200, Vittorio Carlo Alfieri wrote:<br>
> While these changes are good, unfortunately, (for me at least), all these<br>
</span><span class="m_8130274359849966436m_-2251676561364842940gmail-">> I humbly request, if available and not available online somewhere, a copy<br>
> of the git repository used to develop libdxfrw up to the point where it was<br>
> introduced in Qgis in 2016 so that I may continue to bisect the code and<br>
> find the fix for the DWG that I can't open outside of Qgis.<br>
<br>
</span>You're looking for <a href="https://github.com/jef-n/QGIS/commits/dwg-import" rel="noreferrer" target="_blank">https://github.com/jef-n/QGIS/<wbr>commits/dwg-import</a> ?<br></blockquote><div><br></div><div>Wow, yes! Exactly this. I can now continue digging around for the fix. Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="m_8130274359849966436m_-2251676561364842940gmail-"><br>
<br>
> P.S. If the original git repository is still available it would be great if<br>
> placed on Github and possibly even used as a submodule within qgis itself<br>
> so as to have the same git tree as upstream for libdxfrw. This would<br>
> greatly increase harmonization of source code between the various forks of<br>
> libdxfrw and de-duplicate much effort for all parties! I would be willing<br>
> to help implement this for you guys if so desired.<br>
<br>
</span>Isn't libdxfrw dead?<br>
<br>
<a href="https://sourceforge.net/p/libdxfrw/code/ci/65177975f7999fc375813bb50b463554f7395d08/" rel="noreferrer" target="_blank">https://sourceforge.net/p/libd<wbr>xfrw/code/ci/65177975f7999fc37<wbr>5813bb50b463554f7395d08/</a><br>
<br>
is what I started from and it's still the latest commit...<br></blockquote><div><br></div><div>Yeah, I also noticed this. While the Sourceforge repo appears dead, there has been recent</div><div>development for libdxfrw at the following git source trees (amongst others):</div><div><a href="https://github.com/rvt/libdxfrw/commits/master" target="_blank">https://github.com/rvt/libdxfr<wbr>w/commits/master</a><br></div><div><a href="https://github.com/LibreCAD/LibreCAD/commits/master/libraries/libdxfrw/src" target="_blank">https://github.com/LibreCAD/Li<wbr>breCAD/commits/master/librarie<wbr>s/libdxfrw/src</a><br></div><div><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Please note: I am not a member of the LibreCAD team, I am just trying to </span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">fix a bug upstream that is affecting me, and noticed that you had fixed it! </span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Congratulations on your hard work.</span><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div>Personally, I would choose <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><a href="https://github.com/rvt/libdxfrw" target="_blank">https://github.com/rvt/<wbr>libdxfrw</a> as the "upstream" for this library,</span></div><div>for the following reasons:</div><div>1. It contains the entire git source tree, including initial development from Rallaz, the original</div><div>creator of libdxfrw and one of the lead developers of LibreCAD 2.</div><div>2. It is already used as a submodule in the upcoming LibreCAD 3.</div><div>3. Without too much work from the LibreCAD team it can also be used as a submodule in LibreCAD 2.</div><div>4. It is on Github instead of Sourceforge.</div><div>5. It seems to be condoned by Rallaz himself, because the developer, RVT, is also an administrator </div><div>of the SourceForge repo and a member of the LibreCAD team on Github.</div><div><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">In the end it doesn't really matter which git upstream is chosen for the library, as long as the object ID</span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">of the first commit is the same as the original Sourceforge version. This tells git that we are talking </span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">about the same source tree. This is not the case in the current Qgis source tree since libdxfrw </span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">was "forked" </span>from the Qgis source tree.</div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">In my mind, ideally </span>the Qgis project would clone/fork this library, rebase the Qgis specific modifications </div><div>onto the latest upstream version and perform pull-requests for non qgis-specific fixes. </div><div><br></div><div>After this fork is successfully created, it could then be integrated by the Qgis team as a git submodule </div><div>in order to permit merging and re-basing between the various forks of the libdxfrw project </div><div>independently from the Qgis development.</div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div>If this is interesting to you, before performing any changes, I would consult LibreCAD team to make sure </div><div>I'm not way off-base and wrong.</div><div><br></div><div>I would be willing to help, <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">if so desired,<span> </span></span>with any of the following:</div><div>1. Contacting the LibreCAD team to see if rvt/libdxfrw is going to be their upstream going forward.</div><div>2. Rebase your modifications of libdxfrw onto rvt/libdxfrw source tree and create the qgis/libdxfrw fork.</div><div>3. Try to upstream whatever commit fixes the bug that is affecting me.</div><div><br></div><div>Regardless, thank you for the prompt and helpful response,</div><div>Vittorio Alfieri</div><div><br></div><div><br></div></div></div></div>