<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Hi Richard,</p>
    <p>Can you try changing the `!= 't'` to `!= QLatin1String( "t" )`
      and open a PR if that solves the issue? I assume a compiler or old
      Qt version compatibility issue.<br>
    </p>
    <p>And concerning the "is it appropriate to post here", I can't
      answer this question, but in cases like here, where a particular
      line number in a file is mentioned, it's often very efficient to
      comment on this line on github, since the person in charge of the
      change will be notified right away.</p>
    <p>Cheers</p>
    <p>Matthias<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 06/28/2018 01:44 PM, Richard
      Duivenvoorde wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:36f0a411-2cdc-34c6-8da5-6d636327730b@duif.net">
      <pre wrap="">Hi Matthias,

Thanks, meanwhile it is fixed I think?

Now I have this one:

/home/richard/git/qgis/src/providers/postgres/qgspostgresprovider.cpp:
In member function ‘virtual bool QgsPostgresProvider::empty() const’:
/home/richard/git/qgis/src/providers/postgres/qgspostgresprovider.cpp:3203:33:
error: no match for ‘operator!=’ (operand types are ‘QString’ and ‘char’)
   return res.PQgetvalue( 0, 0 ) != 't';
          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
In file included from
/usr/include/x86_64-linux-gnu/qt5/QtCore/qcoreapplication.h:44:0,
                 from
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qapplication.h:43,
                 from
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/QApplication:1,
                 from ../src/core/qgsapplication.h:19,
                 from
/home/richard/git/qgis/src/providers/postgres/qgspostgresprovider.cpp:18:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:1175:13: note:
candidate: bool QString::operator!=(const char*) const <near match>
 inline bool QString::operator!=(const char *s) const
             ^~~~~~~
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:1175:13: note:
conversion of argument 1 would be ill-formed:
/home/richard/git/qgis/src/providers/postgres/qgspostgresprovider.cpp:3203:36:
error: invalid conversion from ‘char’ to ‘const char*’ [-fpermissive]
   return res.PQgetvalue( 0, 0 ) != 't';
                                    ^~~
In file included from
/usr/include/x86_64-linux-gnu/qt5/QtCore/qcoreapplication.h:44:0,


I'm not sure if it is in anyway helpfull to let this know here, as I do
not dare to fix this myself...
But maybe others are trying to compile and fail also.

If devs prefer that I make an issue of these, just let me know.

Regards,

Richard Duivenvoorde

On 06/27/2018 04:02 PM, Matthias Kuhn wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="">Looks like there is a problem with the "final" keyword, probably in
combination with some older versions of sip.

I'm traveling so I don't have the possibility to fix this timely, I'm sorry.

<a class="moz-txt-link-freetext" href="https://github.com/qgis/QGIS/blob/master/python/core/auto_generated/qgsvectordataprovider.sip.in#L134">https://github.com/qgis/QGIS/blob/master/python/core/auto_generated/qgsvectordataprovider.sip.in#L134</a>

Matthias


On 06/27/2018 03:45 PM, Luigi Pirelli wrote:
</pre>
        <blockquote type="cite">
          <pre wrap="">back to 4f25d23fc2e7f1ccf6a2798da78c0fd199fda424 allow successfully build

Luigi Pirelli

**************************************************************************************************
* LinkedIn: <a class="moz-txt-link-freetext" href="https://www.linkedin.com/in/luigipirelli">https://www.linkedin.com/in/luigipirelli</a>
* Stackexchange: <a class="moz-txt-link-freetext" href="http://gis.stackexchange.com/users/19667/luigi-pirelli">http://gis.stackexchange.com/users/19667/luigi-pirelli</a>
* GitHub: <a class="moz-txt-link-freetext" href="https://github.com/luipir">https://github.com/luipir</a>
* Mastering QGIS 2nd Edition:
*
<a class="moz-txt-link-freetext" href="https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition">https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition</a>
* Hire me: <a class="moz-txt-link-freetext" href="http://goo.gl/BYRQKg">http://goo.gl/BYRQKg</a>
**************************************************************************************************


On Wed, 27 Jun 2018 at 14:24, Richard Duivenvoorde
<<a class="moz-txt-link-abbreviated" href="mailto:rdmailings@duif.net">rdmailings@duif.net</a> <a class="moz-txt-link-rfc2396E" href="mailto:rdmailings@duif.net"><mailto:rdmailings@duif.net></a>> wrote:

    Hi Devs,

    I'm having an issue compiling current master:

    [ 47%] Building CXX object
    src/server/CMakeFiles/qgis_server.dir/moc_qgsserverlogger.cpp.o
    [ 47%] Building CXX object
    src/server/CMakeFiles/qgis_server.dir/moc_qgsserversettings.cpp.o
    [ 47%] Linking CXX shared library ../../output/lib/libqgis_server.so
    sip:
    /home/richard/git/qgis/build/python/core/auto_generated/qgsvectordataprovider.sip:134:
    syntax error
    python/CMakeFiles/python_module_qgis__core.dir/build.make:511: recipe
    for target 'python/core/sip_corepart0.cpp' failed
    make[2]: *** [python/core/sip_corepart0.cpp] Error 1
    make[2]: *** Deleting file 'python/core/sip_corepart0.cpp'
    CMakeFiles/Makefile2:3343: recipe for target
    'python/CMakeFiles/python_module_qgis__core.dir/all' failed
    make[1]: *** [python/CMakeFiles/python_module_qgis__core.dir/all]
    Error 2
    make[1]: *** Waiting for unfinished jobs....
    [ 47%] Building CXX object
    src/gui/CMakeFiles/qgis_gui.dir/raster/qgsmultibandcolorrendererwidget.cpp.o
    [ 47%] Building CXX object
    src/gui/CMakeFiles/qgis_gui.dir/raster/qgspalettedrendererwidget.cpp.o
    [ 47%] Building CXX object
    src/gui/CMakeFiles/qgis_gui.dir/raster/qgsrasterbandcombobox.cpp.o
    [ 47%] Building CXX object
    src/gui/CMakeFiles/qgis_gui.dir/raster/qgsrasterhistogramwidget.cpp.o
    [ 47%] Built target qgis_server

    Tried a fresh checkout, and both Ninja and make.

    Anybody else seeing this?

    Regards,

    Richard Duivenvoorde
    _______________________________________________
    QGIS-Developer mailing list
    <a class="moz-txt-link-abbreviated" href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a> <a class="moz-txt-link-rfc2396E" href="mailto:QGIS-Developer@lists.osgeo.org"><mailto:QGIS-Developer@lists.osgeo.org></a>
    List info: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
    Unsubscribe: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>



_______________________________________________
QGIS-Developer mailing list
<a class="moz-txt-link-abbreviated" href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a>
List info: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
Unsubscribe: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
</pre>
        </blockquote>
        <pre wrap="">
-- 
Matthias Kuhn
<a class="moz-txt-link-abbreviated" href="mailto:matthias@opengis.ch">matthias@opengis.ch</a> <a class="moz-txt-link-rfc2396E" href="mailto:matthias@opengis.ch"><mailto:matthias@opengis.ch></a>
+41 (0)76 435 67 63 <tel:+41764356763>
OPENGIS.ch Logo <a class="moz-txt-link-rfc2396E" href="http://www.opengis.ch"><http://www.opengis.ch></a>


_______________________________________________
QGIS-Developer mailing list
<a class="moz-txt-link-abbreviated" href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a>
List info: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
Unsubscribe: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>

</pre>
      </blockquote>
      <pre wrap="">
_______________________________________________
QGIS-Developer mailing list
<a class="moz-txt-link-abbreviated" href="mailto:QGIS-Developer@lists.osgeo.org">QGIS-Developer@lists.osgeo.org</a>
List info: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>
Unsubscribe: <a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/qgis-developer">https://lists.osgeo.org/mailman/listinfo/qgis-developer</a>

</pre>
    </blockquote>
    <br>
    <div class="moz-signature">-- <br>
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div class="moz-signature">
        <title></title>
        <div class="moz-signature"> <span style="text-align: left;
            color: #000000; font-family: 'Verdana', sans-serif;
            font-size: 10pt">Matthias Kuhn</span><br>
          <a href="mailto:matthias@opengis.ch" target="_blank"> <span
              style="text-align: left; color: #000000; font-family:
              'Verdana', sans-serif; font-size: 8pt">matthias@opengis.ch</span>
          </a><br>
          <span style="text-align: left; color: #000000; font-family:
            'Verdana', sans-serif; font-size: 8pt"><a
              href="tel:+41764356763">+41 (0)76 435 67 63</a></span><br>
          <div> <a href="http://www.opengis.ch"> <img
                moz-do-not-send="false"
                src="cid:part3.70C5901A.135C0EF3@opengis.ch"
                alt="OPENGIS.ch Logo" width="200" height="80"></a> </div>
        </div>
      </div>
    </div>
  </body>
</html>